Skip to content

Move Linux desktop runner source to a runner/ subfolder #60213

Closed
#153812
Closed
Move Linux desktop runner source to a runner/ subfolder#60213
#153812
Labels
P3Issues that are less important to the Flutter projecta: desktopRunning on desktopc: tech-debtTechnical debt, code quality, testing, etc.platform-linuxBuilding on or for Linux specificallyteam-linuxOwned by the Linux platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-linuxTriaged by the Linux platform team

Description

@stuartmorgan-g
stuartmorgan-g
opened on Jun 24, 2020

Most of the other platforms have the runner code in a runner/ subdirectory; I meant to go back and do that for Linux, but didn't get to it. We should move the source for consistency, and to make the linux/ folder more organized. As part of that, we can move the application-specific part of the CMakeLists.txt into that folder, which makes the build rules easier to navigate.

This won't be a breaking change, because apps made with the old template will still work. But we should do it ASAP to reduce the number of people with different directory structures in the wild since it'll be a little confusing for people looking at other projects, answering questions about where to change things in native code, etc.

@robert-ancell If you have time to do this that would be great, otherwise I can probably do it.

Activity

  1. stuartmorgan-g
    added
    toolAffects the "flutter" command-line tool. See also t: labels.
    platform-linuxBuilding on or for Linux specifically
    a: desktopRunning on desktop
    on Jun 24, 2020
  2. robert-ancell
    self-assigned this
    on Jun 25, 2020
  3. gspencergoog
    added
    P2Important issues not at the top of the work list
    on Oct 14, 2020
  4. pedromassangocode
    added
    passed first triage
    on Mar 1, 2021
  5. flutter-triage-bot
    added
    multiteam-retriage-candidate
    team-desktop
    triaged-desktop
    and removed
    triaged-desktop
    on Jul 7, 2023

  6. flutter-triage-bot commented on Jul 8, 2023

    @flutter-triage-bot
    flutter-triage-botbot
    on Jul 8, 2023

    This issue is assigned but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

  7. Hixie
    removed
    passed first triage
    on Jul 8, 2023
  8. flutter-triage-bot
    added
    ⏳Bot is counting down the days until it unassigns the issue
    on Nov 25, 2023

  9. flutter-triage-bot commented on Nov 25, 2023

    @flutter-triage-bot
    flutter-triage-botbot
    on Nov 25, 2023

    This issue is assigned to @robert-ancell but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

  10. robert-ancell
    removed their assignment
    on Jan 16, 2024

  11. 1 remaining item

  12. cbracken
    added
    triaged-desktop
    P3Issues that are less important to the Flutter project
    c: tech-debtTechnical debt, code quality, testing, etc.
    and removed
    P2Important issues not at the top of the work list
    on Jan 18, 2024
  13. Hixie
    removed
    multiteam-retriage-candidate
    on Mar 6, 2024
  14. cbracken
    added
    team-linuxOwned by the Linux platform team
    and removed
    team-desktop
    on Jun 6, 2024
  15. flutter-triage-bot
    removed
    triaged-desktop
    on Jun 6, 2024

  16. flutter-triage-bot commented on Jun 6, 2024

    @flutter-triage-bot
    flutter-triage-botbot
    on Jun 6, 2024

    The triaged-desktop label is irrelevant if there is no team-desktop label or fyi-desktop label.

  17. jmagman
    added
    triaged-linuxTriaged by the Linux platform team
    on Jun 7, 2024
  18. robert-ancell
    added a commit that references this issue on Sep 25, 2024

    Move the Linux runner into a subdirectory (#153812)

    8925e1f
  19. robert-ancell
    closed this as completedin #153812on Sep 25, 2024
  20. thejitenpatel
    added a commit that references this issue on Sep 26, 2024

    Move the Linux runner into a subdirectory (flutter#153812)

    ba4efed

  21. github-actions commented on Oct 10, 2024

    @github-actions
    github-actionsbot
    on Oct 10, 2024 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  22. github-actions
    locked as resolved and limited conversation to collaborators on Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projecta: desktopRunning on desktopc: tech-debtTechnical debt, code quality, testing, etc.platform-linuxBuilding on or for Linux specificallyteam-linuxOwned by the Linux platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-linuxTriaged by the Linux platform team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions