Skip to content

Engine roll failed post-submit verify-binaries-signed-macos test #60296

Closed
#60391
Closed
Engine roll failed post-submit verify-binaries-signed-macos test#60296
#60391
Labels
c: contributor-productivityTeam-specific productivity, code health, technical debt.team-infraOwned by Infrastructure team

Description

@christopherfujino
christopherfujino
opened on Jun 25, 2020

This engine roll #60254 failed this https://cirrus-ci.com/task/5637314439282688.

This test is not supposed to run on master.

This was temporarily skipped, and the skip landed on dev 1.20.0-2.0.pre.

Activity

  1. christopherfujino
    added
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    team-infraOwned by Infrastructure team
    on Jun 25, 2020

  2. christopherfujino commented on Jun 25, 2020

    @christopherfujino
    christopherfujino
    on Jun 25, 2020
    ContributorAuthor

    I believe @fkorotkov is currently investigating.

  3. fkorotkov commented on Jun 25, 2020

    @fkorotkov
    fkorotkov
    on Jun 25, 2020
    Contributor

    Indeed the task had CIRRUS_BASE_BRANCH set to dev which means a corresponding Check Suite event had base.ref set to dev. Here is the webhook event:

    Details 
    {
  "action": "requested",
  "check_suite": {
    "id": 841735204,
    "node_id": "MDEwOkNoZWNrU3VpdGU4NDE3MzUyMDQ=",
    "head_branch": "master",
    "head_sha": "5d2c8694bcc0e1942ef0e4876c8a106e1b537adf",
    "status": "queued",
    "conclusion": null,
    "url": "https://api.github.com/repos/flutter/flutter/check-suites/841735204",
    "before": "c68758fab137f751d56faa1ced119b7a3561e37e",
    "after": "5d2c8694bcc0e1942ef0e4876c8a106e1b537adf",
    "pull_requests": [
      {
        "url": "https://api.github.com/repos/flutter/flutter/pulls/60287",
        "id": 440064516,
        "number": 60287,
        "head": {
          "ref": "master",
          "sha": "c68758fab137f751d56faa1ced119b7a3561e37e",
          "repo": {
            "id": 31792824,
            "url": "https://api.github.com/repos/flutter/flutter",
            "name": "flutter"
          }
        },
        "base": {
          "ref": "dev",
          "sha": "f73f498da1fe4224e29cf9692161575a3d994f8f",
          "repo": {
            "id": 31792824,
            "url": "https://api.github.com/repos/flutter/flutter",
            "name": "flutter"
          }
        }
      },
      {
        "url": "https://api.github.com/repos/25ma/flutter/pulls/1",
        "id": 419879049,
        "number": 1,
        "head": {
          "ref": "master",
          "sha": "c68758fab137f751d56faa1ced119b7a3561e37e",
          "repo": {
            "id": 31792824,
            "url": "https://api.github.com/repos/flutter/flutter",
            "name": "flutter"
          }
        },
        "base": {
          "ref": "master",
          "sha": "f41becf53e4a339bd521d7ca56a2ef53bbed55ab",
          "repo": {
            "id": 218183782,
            "url": "https://api.github.com/repos/25ma/flutter",
            "name": "flutter"
          }
        }
      },
      {
        "url": "https://api.github.com/repos/HongZhiQing/flutter/pulls/1",
        "id": 415571600,
        "number": 1,
        "head": {
          "ref": "master",
          "sha": "c68758fab137f751d56faa1ced119b7a3561e37e",
          "repo": {
            "id": 31792824,
            "url": "https://api.github.com/repos/flutter/flutter",
            "name": "flutter"
          }
        },
        "base": {
          "ref": "master",
          "sha": "812885c179072a5d3a221c6f0e290ad60d631ad0",
          "repo": {
            "id": 255233784,
            "url": "https://api.github.com/repos/HongZhiQing/flutter",
            "name": "flutter"
          }
        }
      },
      {
        "url": "https://api.github.com/repos/oofimaconsumer/flutter/pulls/3",
        "id": 403605115,
        "number": 3,
        "head": {
          "ref": "master",
          "sha": "c68758fab137f751d56faa1ced119b7a3561e37e",
          "repo": {
            "id": 31792824,
            "url": "https://api.github.com/repos/flutter/flutter",
            "name": "flutter"
          }
        },
        "base": {
          "ref": "master",
          "sha": "1ef35e11f23f7716f212d98f2cffb3cffb743e01",
          "repo": {
            "id": 246471956,
            "url": "https://api.github.com/repos/oofimaconsumer/flutter",
            "name": "flutter"
          }
        }
      },
      {
        "url": "https://api.github.com/repos/Vadaski/flutter/pulls/1",
        "id": 394526365,
        "number": 1,
        "head": {
          "ref": "master",
          "sha": "c68758fab137f751d56faa1ced119b7a3561e37e",
          "repo": {
            "id": 31792824,
            "url": "https://api.github.com/repos/flutter/flutter",
            "name": "flutter"
          }
        },
        "base": {
          "ref": "master",
          "sha": "d5a243fada31ed7712b3930d5e78762af2c5a36a",
          "repo": {
            "id": 224116277,
            "url": "https://api.github.com/repos/Vadaski/flutter",
            "name": "flutter"
          }
        }
      }
    ],
    "app": {
      "id": 3232,
      "slug": "cirrus-ci",
      "node_id": "MDM6QXBwMzIzMg==",
      "owner": {
        "login": "cirruslabs",
        "id": 29414678,
        "node_id": "MDEyOk9yZ2FuaXphdGlvbjI5NDE0Njc4",
        "avatar_url": "https://avatars2.githubusercontent.com/u/29414678?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/cirruslabs",
        "html_url": "https://github.com/cirruslabs",
        "followers_url": "https://api.github.com/users/cirruslabs/followers",
        "following_url": "https://api.github.com/users/cirruslabs/following{/other_user}",
        "gists_url": "https://api.github.com/users/cirruslabs/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/cirruslabs/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/cirruslabs/subscriptions",
        "organizations_url": "https://api.github.com/users/cirruslabs/orgs",
        "repos_url": "https://api.github.com/users/cirruslabs/repos",
        "events_url": "https://api.github.com/users/cirruslabs/events{/privacy}",
        "received_events_url": "https://api.github.com/users/cirruslabs/received_events",
        "type": "Organization",
        "site_admin": false
      },
      "name": "Cirrus CI",
      "description": "Cirrus CI makes your development cycle fast, efficient, and secure by leveraging modern cloud technologies. Cirrus CI scales with your team and makes shipping software faster and cheaper.",
      "external_url": "https://cirrus-ci.com",
      "html_url": "https://github.com/apps/cirrus-ci",
      "created_at": "2017-06-21T15:35:40Z",
      "updated_at": "2018-08-27T11:48:50Z",
      "permissions": {
        "checks": "write",
        "contents": "read",
        "content_references": "write",
        "members": "read",
        "metadata": "read",
        "pull_requests": "read",
        "single_file": "read",
        "statuses": "write"
      },
      "events": [
        "check_suite",
        "content_reference",
        "create",
        "delete",
        "public",
        "pull_request",
        "push",
        "release",
        "repository"
      ]
    },
    "created_at": "2020-06-25T16:18:23Z",
    "updated_at": "2020-06-25T16:18:23Z",
    "latest_check_runs_count": 0,
    "check_runs_url": "https://api.github.com/repos/flutter/flutter/check-suites/841735204/check-runs",
    "head_commit": {
      "id": "5d2c8694bcc0e1942ef0e4876c8a106e1b537adf",
      "tree_id": "dd015cafeae7e203842876cb3b9ac089718defdd",
      "message": "Roll Engine from 0c141262115f to 73ff2bdd36ab (3 revisions) (#60254)",
      "timestamp": "2020-06-25T16:18:02Z",
      "author": {
        "name": "engine-flutter-autoroll",
        "email": "[email protected]"
      },
      "committer": {
        "name": "GitHub",
        "email": "[email protected]"
      }
    }
  },
  "repository": {
    "id": 31792824,
    "node_id": "MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==",
    "name": "flutter",
    "full_name": "flutter/flutter",
    "private": false,
    "owner": {
      "login": "flutter",
      "id": 14101776,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2",
      "avatar_url": "https://avatars3.githubusercontent.com/u/14101776?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/flutter",
      "html_url": "https://github.com/flutter",
      "followers_url": "https://api.github.com/users/flutter/followers",
      "following_url": "https://api.github.com/users/flutter/following{/other_user}",
      "gists_url": "https://api.github.com/users/flutter/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/flutter/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/flutter/subscriptions",
      "organizations_url": "https://api.github.com/users/flutter/orgs",
      "repos_url": "https://api.github.com/users/flutter/repos",
      "events_url": "https://api.github.com/users/flutter/events{/privacy}",
      "received_events_url": "https://api.github.com/users/flutter/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "html_url": "https://github.com/flutter/flutter",
    "description": "Flutter makes it easy and fast to build beautiful apps for mobile and beyond.",
    "fork": false,
    "url": "https://api.github.com/repos/flutter/flutter",
    "forks_url": "https://api.github.com/repos/flutter/flutter/forks",
    "keys_url": "https://api.github.com/repos/flutter/flutter/keys{/key_id}",
    "collaborators_url": "https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}",
    "teams_url": "https://api.github.com/repos/flutter/flutter/teams",
    "hooks_url": "https://api.github.com/repos/flutter/flutter/hooks",
    "issue_events_url": "https://api.github.com/repos/flutter/flutter/issues/events{/number}",
    "events_url": "https://api.github.com/repos/flutter/flutter/events",
    "assignees_url": "https://api.github.com/repos/flutter/flutter/assignees{/user}",
    "branches_url": "https://api.github.com/repos/flutter/flutter/branches{/branch}",
    "tags_url": "https://api.github.com/repos/flutter/flutter/tags",
    "blobs_url": "https://api.github.com/repos/flutter/flutter/git/blobs{/sha}",
    "git_tags_url": "https://api.github.com/repos/flutter/flutter/git/tags{/sha}",
    "git_refs_url": "https://api.github.com/repos/flutter/flutter/git/refs{/sha}",
    "trees_url": "https://api.github.com/repos/flutter/flutter/git/trees{/sha}",
    "statuses_url": "https://api.github.com/repos/flutter/flutter/statuses/{sha}",
    "languages_url": "https://api.github.com/repos/flutter/flutter/languages",
    "stargazers_url": "https://api.github.com/repos/flutter/flutter/stargazers",
    "contributors_url": "https://api.github.com/repos/flutter/flutter/contributors",
    "subscribers_url": "https://api.github.com/repos/flutter/flutter/subscribers",
    "subscription_url": "https://api.github.com/repos/flutter/flutter/subscription",
    "commits_url": "https://api.github.com/repos/flutter/flutter/commits{/sha}",
    "git_commits_url": "https://api.github.com/repos/flutter/flutter/git/commits{/sha}",
    "comments_url": "https://api.github.com/repos/flutter/flutter/comments{/number}",
    "issue_comment_url": "https://api.github.com/repos/flutter/flutter/issues/comments{/number}",
    "contents_url": "https://api.github.com/repos/flutter/flutter/contents/{+path}",
    "compare_url": "https://api.github.com/repos/flutter/flutter/compare/{base}...{head}",
    "merges_url": "https://api.github.com/repos/flutter/flutter/merges",
    "archive_url": "https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}",
    "downloads_url": "https://api.github.com/repos/flutter/flutter/downloads",
    "issues_url": "https://api.github.com/repos/flutter/flutter/issues{/number}",
    "pulls_url": "https://api.github.com/repos/flutter/flutter/pulls{/number}",
    "milestones_url": "https://api.github.com/repos/flutter/flutter/milestones{/number}",
    "notifications_url": "https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}",
    "labels_url": "https://api.github.com/repos/flutter/flutter/labels{/name}",
    "releases_url": "https://api.github.com/repos/flutter/flutter/releases{/id}",
    "deployments_url": "https://api.github.com/repos/flutter/flutter/deployments",
    "created_at": "2015-03-06T22:54:58Z",
    "updated_at": "2020-06-25T16:17:22Z",
    "pushed_at": "2020-06-25T16:18:03Z",
    "git_url": "git://github.com/flutter/flutter.git",
    "ssh_url": "[email protected]:flutter/flutter.git",
    "clone_url": "https://github.com/flutter/flutter.git",
    "svn_url": "https://github.com/flutter/flutter",
    "homepage": "https://flutter.dev",
    "size": 106367,
    "stargazers_count": 94808,
    "watchers_count": 94808,
    "language": "Dart",
    "has_issues": true,
    "has_projects": true,
    "has_downloads": true,
    "has_wiki": true,
    "has_pages": false,
    "forks_count": 13045,
    "mirror_url": null,
    "archived": false,
    "disabled": false,
    "open_issues_count": 7891,
    "license": {
      "key": "bsd-3-clause",
      "name": "BSD 3-Clause \"New\" or \"Revised\" License",
      "spdx_id": "BSD-3-Clause",
      "url": "https://api.github.com/licenses/bsd-3-clause",
      "node_id": "MDc6TGljZW5zZTU="
    },
    "forks": 13045,
    "open_issues": 7891,
    "watchers": 94808,
    "default_branch": "master"
  },
  "organization": {
    "login": "flutter",
    "id": 14101776,
    "node_id": "MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2",
    "url": "https://api.github.com/orgs/flutter",
    "repos_url": "https://api.github.com/orgs/flutter/repos",
    "events_url": "https://api.github.com/orgs/flutter/events",
    "hooks_url": "https://api.github.com/orgs/flutter/hooks",
    "issues_url": "https://api.github.com/orgs/flutter/issues",
    "members_url": "https://api.github.com/orgs/flutter/members{/member}",
    "public_members_url": "https://api.github.com/orgs/flutter/public_members{/member}",
    "avatar_url": "https://avatars3.githubusercontent.com/u/14101776?v=4",
    "description": ""
  },
  "enterprise": {
    "id": 1732,
    "slug": "alphabet",
    "name": "Alphabet",
    "node_id": "MDEwOkVudGVycHJpc2UxNzMy",
    "avatar_url": "https://avatars2.githubusercontent.com/b/1732?v=4",
    "description": "",
    "website_url": "https://abc.xyz/",
    "html_url": "https://github.com/enterprises/alphabet",
    "created_at": "2019-12-19T00:30:52Z",
    "updated_at": "2019-12-19T21:05:17Z"
  },
  "sender": {
    "login": "fluttergithubbot",
    "id": 52682268,
    "node_id": "MDQ6VXNlcjUyNjgyMjY4",
    "avatar_url": "https://avatars2.githubusercontent.com/u/52682268?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/fluttergithubbot",
    "html_url": "https://github.com/fluttergithubbot",
    "followers_url": "https://api.github.com/users/fluttergithubbot/followers",
    "following_url": "https://api.github.com/users/fluttergithubbot/following{/other_user}",
    "gists_url": "https://api.github.com/users/fluttergithubbot/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/fluttergithubbot/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/fluttergithubbot/subscriptions",
    "organizations_url": "https://api.github.com/users/fluttergithubbot/orgs",
    "repos_url": "https://api.github.com/users/fluttergithubbot/repos",
    "events_url": "https://api.github.com/users/fluttergithubbot/events{/privacy}",
    "received_events_url": "https://api.github.com/users/fluttergithubbot/received_events",
    "type": "User",
    "site_admin": false
  },
  "installation": {
    "id": 104037,
    "node_id": "MDIzOkludGVncmF0aW9uSW5zdGFsbGF0aW9uMTA0MDM3"
  }
}

    As you can see pull_requests field doesn't make sense. It refers this weird PR #60287. From the Cirrus perspective this looked like a PR created from master to dev. 😳

  4. christopherfujino commented on Jun 26, 2020

    @christopherfujino
    christopherfujino
    on Jun 26, 2020
    ContributorAuthor

    I'm not sure how to read that webhook. Is that a batch request corresponding to multiple PRs? I can see that PR #60287 had the same revision at the tip, 5d2c869. I'm not sure how that webhook lead to triggering this build that looks like a post-submit run https://cirrus-ci.com/task/5637314439282688. Is the webhook malformed or is the parsing of it ambiguous?

  5. fkorotkov commented on Jun 26, 2020

    @fkorotkov
    fkorotkov
    on Jun 26, 2020
    Contributor

    Yes, IMO the webhook is malformed. Since you mentioned this conditioned worked for a long time I think we can ignore it for now. If that'll re-occurs we'll need to involve GH support.

  6. christopherfujino commented on Jun 26, 2020

    @christopherfujino
    christopherfujino
    on Jun 26, 2020
    ContributorAuthor

    Yes, IMO the webhook is malformed. Since you mentioned this conditioned worked for a long time I think we can ignore it for now. If that'll re-occurs we'll need to involve GH support.

    SGTM. Thanks for investigating!

  7. christopherfujino commented on Jun 26, 2020

    @christopherfujino
    christopherfujino
    on Jun 26, 2020
    ContributorAuthor

    Per discussion above, I will close this issue. If it happens again follow-up with GitHub support will be necessary.

  8. christopherfujino
    closed this as completedon Jun 26, 2020
  9. christopherfujino
    reopened this on Jun 26, 2020
  10. fluttergithubbot
    closed this as completedin #60391on Jun 29, 2020

  11. github-actions commented on Aug 19, 2021

    @github-actions
    github-actionsbot
    on Aug 19, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  12. github-actions
    locked as resolved and limited conversation to collaborators on Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c: contributor-productivityTeam-specific productivity, code health, technical debt.team-infraOwned by Infrastructure team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions