Flat buttons are supposed to have a 48px high tap target #615

Activity

1. Hixie

   added

   c: new featureNothing broken; request for a new capabilityNothing broken; request for a new capability

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   p: material_uimaterial_ui package in flutter/packagesmaterial_ui package in flutter/packages

   on Nov 29, 2015
2. Hixie

   added this to the Blue SkyThis milestone has been deleted milestone on Nov 29, 2015
3. abarth commented on Nov 30, 2015

   

   abarth

   on Nov 30, 2015

   Contributor

   More actions

   Do you know how the splashes are supposed to work when you tap outside the visual bounds of the button? Should the splash start at the closest point inside the button? Should the splash originate from a point that's clipped by the button's visual bounds? Should the splash be omitted?
4. Hixie commented on Nov 30, 2015

   

   Hixie

   on Nov 30, 2015

   ContributorAuthor

   More actions

   The spec doesn't say.
5. abarth commented on Nov 30, 2015

   

   abarth

   on Nov 30, 2015

   Contributor

   More actions

   We should experiment with other implementations and/or ask the spec authors. This issue is what blocked me from solving this problem before.
6. Hixie commented on Nov 30, 2015

   

   Hixie

   on Nov 30, 2015

   ContributorAuthor

   More actions

   I've sent a question to the material design team about this.

   On Sun, Nov 29, 2015 at 4:55 PM Adam Barth [email protected] wrote:

   We should experiment with other implementations and/or ask the spec
   authors. This issue is what blocked me from solving this problem before.

   —
   Reply to this email directly or view it on GitHub
   #615 (comment).
7. sethladd commented on Jan 7, 2016

   

   sethladd

   on Jan 7, 2016

   Contributor

   More actions

   Did we ever get an answer?
8. Hixie commented on Jan 7, 2016

   

   Hixie

   on Jan 7, 2016

   ContributorAuthor

   More actions

   We got several. Fundamentally there's no good answer because this is a non-physical interaction (tapping just outside the button triggering a button press). I think the best compromise between implementation complexity and quality of experience here is for the splash to start at the edge of the button nearest the actual tap point. It'll feel like you hit the button with the side of your finger and that's what triggered it.

   👍React with 👍1Reacted by Linus Unnebäck
9. Hixie

   added

   a: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)

   on Jun 13, 2017
10. Hixie

    modified the milestones: 3: Current Milestone, 5: Make Hixie proudThis milestone has been deleted on Jun 13, 2017
11. Hixie commented on Dec 13, 2017

    

    Hixie

    on Dec 13, 2017

    ContributorAuthor

    More actions

    This is on our radar for the coming months.
12. Hixie

    modified the milestones: 3: Current Milestone, 4: Next milestoneThis milestone has been deleted on Jan 26, 2018
13. goderbauer

    added

    from: a11y reviewReported by an accessibility review teamReported by an accessibility review team

    on Mar 7, 2018
14. Hixie

    modified the milestones: 3: Current Milestone, 4: Next milestoneThis milestone has been deleted on Apr 11, 2018
15. jonahwilliams

    self-assigned this

    on May 30, 2018
16. jonahwilliams

    closed this as completedin #18369on Jul 3, 2018
17. github-actions commented on Aug 17, 2021

    

    github-actionsbot

    on Aug 17, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
18. github-actions

    locked as resolved and limited conversation to collaborators on Aug 17, 2021