Skip to content

TableRow.toString() logic is inverted for non-null populated lists #6351

Closed

Description

@darthvadrismydad

Simple inverted logic with a list null check.

Offending Code in the master branch

Steps to Reproduce

  1. Create a TableRow instance
  2. set the children on the TableRow with a list which contains at least one object
  3. call TableRow.toString()
  4. String will output "child list is null" because the logic is the opposite of what it should be.

Activity

  1. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Oct 16, 2016
  2. eseidelGoogle commented on Oct 16, 2016

    @eseidelGoogle
    Contributor
  3. self-assigned this
    on Oct 17, 2016
  4. added a commit that references this issue on Oct 17, 2016
    1043011
  5. abarth commented on Oct 17, 2016

    @abarth
    Contributor

    Thanks for the report!

  6. abarth commented on Oct 17, 2016

    @abarth
    Contributor

    Looks like a trivial fix. :P

  7. added a commit that references this issue on Oct 17, 2016
    e81e06a
  8. added a commit that references this issue on Sep 27, 2018
  9. github-actions commented on Sep 5, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  10. locked as resolved and limited conversation to collaborators on Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

frameworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions