Skip to content

Support Flutter SDK paths with spaces #6577

Closed

Description

@cbracken

Steps to Reproduce

  1. Install the SDK in a path containing spaces. e.g., /Users/someone/Google Drive/Development/dart/flutter-sdk.
  2. Run flutter doctor
$ flutter doctor
...
/Users/someone/Google Drive/Development/dart/flutter-sdk/bin/flutter: line 50: $PROG_NAME: ambiguous redirect

Activity

  1. added
    toolAffects the "flutter" command-line tool. See also t: labels.
    on Oct 28, 2016
  2. self-assigned this
    on Oct 28, 2016
  3. cbracken commented on Feb 9, 2017

    @cbracken
    MemberAuthor

    flutter doctor is now working. What's still left to do:

    • Add quotes around the xcode_backend.sh path in the two build phases we call it in the project templates + all examples.
    • A ton of quoting in xcode_backend.sh itself.
    • flutter run on both Android and iOS
    • probably more :)
  4. changed the title [-]Flutter doctor fails when Flutter SDK install path contains spaces[/-] [+]Support Flutter SDK paths with spaces[/+] on Feb 9, 2017
  5. cbracken commented on Feb 9, 2017

    @cbracken
    MemberAuthor

    Now working:

    • xcode_backend.sh is cleaned up
    • iOS Xcode project templates updated.
    • flutter build ios

    What's still not working:

    • flutter run with and without hot reload.
  6. cbracken commented on Feb 10, 2017

    @cbracken
    MemberAuthor

    There's also a bug in the engine (specifically in the Tonic loader) wherein file:// URIs are not URI-decoded during conversion to filesystem paths. I'll put together a patch and send upstream.

  7. added this to the milestone on Feb 27, 2017
  8. added
    engineflutter/engine related. See also e: labels.
    on Jun 2, 2017
  9. cbracken commented on Jun 30, 2017

    @cbracken
    MemberAuthor

    Note: dart-lang/sdk#30059 is a blocker for this.

  10. Hixie commented on Dec 13, 2017

    @Hixie
    Contributor

    @bkonyi You did this right?

  11. cbracken commented on Dec 13, 2017

    @cbracken
    MemberAuthor

    This is done in the engine. We still need to verify nothing has regressed in the tooling, then the last remaining task here is to configure the build bot recipes with a space in the SDK path to ensure we don't regress this.

  12. 15 remaining items

  13. cbracken commented on Feb 10, 2018

    @cbracken
    MemberAuthor

    This is now resolved. Travis/Appveyor are updated to run all tests in a flutter SDK directory named "flutter sdk".

  14. cbracken commented on Feb 10, 2018

    @cbracken
    MemberAuthor

    As an added bonus, we now also support any path that's a valid UTF-8 string. This assumes UTF-8 encoding of paths in your filesystem, which isn't strictly-speaking a safe assumption everywhere.

  15. Hixie commented on Feb 12, 2018

    @Hixie
    Contributor

    This patch had a minor regressive impact on the aot_snapshot size metrics.

  16. Hixie commented on Feb 12, 2018

    @Hixie
    Contributor

    Please disregard my most recent comment.

  17. github-actions commented on Sep 3, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  18. locked as resolved and limited conversation to collaborators on Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

engineflutter/engine related. See also e: labels.toolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions