Repository navigation
[flutter_tools] Migrate hostonly_devicelab tests to flutter_tools #65790
Copy link
Copy link
Open
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: flakeTests that sometimes, but not always, incorrectly passTests that sometimes, but not always, incorrectly passteam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.Issues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool teamTriaged by Flutter Tool team
Description
Most of the hostonly_devicelab tests can and should be migrated to //flutter/packages/flutter_tools/test/integration.shard.
Can be migrated
- plugin_test
- plugin_lint_mac
- build_ios_framework_module_test
- plugin_dependencies_test
- module_test
- Improve hard-coded pubspecs
- Move analytics verification to a smaller test
- module_custom_host_app_name_test
- Possibly merge with module_test?
- module_host_with_custom_build_test
- Maybe? See module_test et al
-
gradle_r8_testremoved with [devicelab] turn down android X migration gradle tests #68110 - gradle_plugin_light_apk_test
- gradle_plugin_fat_apk_test
- Possible merge/dedupe with light version?
- gradle_deprecated_settings_test ([flutter_tools] port deprecated settings test to flutter integration shard #65806)
- gradle_non_android_plugin_test (Move gradle_non_android_plugin_test from its own test builders into tools integration.shard #80161)
-
gradle_jetifier_testremoved with [devicelab] turn down android X migration gradle tests #68110- Has hard-coded pubspec
-
gradle_fast_start_testremoved with Revert "Revert "delete fast start unit test"" #67765 - build_aar_module_test
Cannot be migrated
- web_benchmarks
- module_test_ios
- because it uses simulator
- Probably should improve hard-coded pubspecs
Retire
- flutter_create_offline_test_mac and windows and linux ([ci] remove create offline tests #65791)
- These tests are not strictly correct, and provide minimal value.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: flakeTests that sometimes, but not always, incorrectly passTests that sometimes, but not always, incorrectly passteam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.Issues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool teamTriaged by Flutter Tool team
Activity
christopherfujino commentedon Sep 14, 2020
cc @jonahwilliams
jonahwilliams commentedon Sep 14, 2020
Some other general improvements:
We should:
This may also involve retiring some of dev/devicelab
[flutter_tools] port deprecated settings test to flutter integration …
jmagman commentedon Dec 11, 2020
Why can we not use the simulator to run unit tests in
module_test_iosin a tool integration test?christopherfujino commentedon Dec 11, 2020
Good question, idk.
jmagman commentedon Jan 22, 2021
android_plugin_example_app_build_testis also a candidate.