Skip to content

[flutter_tools] Migrate hostonly_devicelab tests to flutter_tools #65790

Open

Description

@christopherfujino

Most of the hostonly_devicelab tests can and should be migrated to //flutter/packages/flutter_tools/test/integration.shard.

Can be migrated

Cannot be migrated

  • web_benchmarks
  • module_test_ios
    • because it uses simulator
    • Probably should improve hard-coded pubspecs

Retire

Activity

  1. christopherfujino commented on Sep 14, 2020

    @christopherfujino
    ContributorAuthor
  2. jonahwilliams commented on Sep 14, 2020

    @jonahwilliams
    Contributor

    Some other general improvements:

    We should:

    • Avoid downloading additional dependencies from the net.
    • Simplify and compress as many of the tests as possible. i.e. using a single host android application for multiple test cases, or perform fewer rebuilds of APKs.
    • Rewrite tests to be simpler when possible, i.e. avoid building a full app if a smaller command is sufficient to confirm behavior. Remove test assertions that are already covered elsewhere or could be unit tests instead.

    This may also involve retiring some of dev/devicelab

  3. added
    P3Issues that are less important to the Flutter project
    on Sep 24, 2020
  4. jmagman commented on Dec 11, 2020

    @jmagman
    Member

    Cannot be migrated

    • module_test_ios
      • because it uses simulator

    Why can we not use the simulator to run unit tests in module_test_ios in a tool integration test?

  5. christopherfujino commented on Dec 11, 2020

    @christopherfujino
    ContributorAuthor

    Cannot be migrated

    • module_test_ios

      • because it uses simulator

    Why can we not use the simulator to run unit tests in module_test_ios in a tool integration test?

    Good question, idk.

  6. jmagman commented on Jan 22, 2021

    @jmagman
    Member

    android_plugin_example_app_build_test is also a candidate.

  7. added
    c: flakeTests that sometimes, but not always, incorrectly pass
    team-toolOwned by Flutter Tool team
    triaged-toolTriaged by Flutter Tool team
    on Jul 7, 2023
  8. added
    tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.
    on Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.c: flakeTests that sometimes, but not always, incorrectly passteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions