Skip to content

[pigeon] Use List instead of ArrayList on generated Java pigeon entries #66453

Closed
Closed
[pigeon] Use List instead of ArrayList on generated Java pigeon entries#66453
Labels
p: pigeonrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.

Description

@matejdro
matejdro
opened on Sep 23, 2020

Minor, but useful enhancement.

Currently, following pigeon class:

class Response {
  List<String> details;
}

generates following java version:

  public static class Response {
    private ArrayList details;
    public ArrayList getDetails() { return details; }
    public void setDetails(ArrayList setterArg) { this.details = setterArg; }

    ...
  }

However, from what I see, there is really no reason why details here is specifically ArrayList. It should just be List, which allows developer to pass any kind of list.

Primary use case here are transformation methods, for example Kotlin's list.map {} method which just return ordinary List. At the moment, there is additional overhead of transforming whatever list Kotlin generates into ArrayList.

(This is with Pigeon 0.1.6)

@gaaclarke

Activity

  1. xster
    added
    p: pigeonrelated to pigeon messaging codegen tool
    on Sep 24, 2020
  2. darshankawar
    added
    p: first party
    passed first triage
    plugin
    on Sep 25, 2020
  3. matejdro
    added a commit that references this issue on Oct 5, 2020

    [pigeon] use generic Map and List instead of specific ArrayList and H…

    efbe0e4
  4. gaaclarke
    added a commit that references this issue on Mar 1, 2021

    [pigeon] use generic Map and List instead of specific ArrayList and H…

    d0cb3e6
  5. gaaclarke
    closed this as completedin 958ce10on Mar 1, 2021

  6. github-actions commented on Aug 5, 2021

    @github-actions
    github-actionsbot
    on Aug 5, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. github-actions
    locked as resolved and limited conversation to collaborators on Aug 5, 2021
  8. flutter-triage-bot
    added
    packageflutter/packages repository. See also p: labels.
    on Jul 5, 2023
  9. creatorpiyush
    added a commit that references this issue on Jun 10, 2026

    [pigeon] Improve java generation (flutter#214)

    2c9d7fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    p: pigeonrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions