Repository navigation
[doc] BottomNavigationBarItem : Update title with label to reflect correct message. #67185
Description
I noticed that the API documentation for BottomNavigationBarItem is out of date.
It mentions:
The argument
iconshould not be null and the argumenttitleshould not be null when used in a Material Design's BottomNavigationBar.
However, since title is now deprecated, shouldn't this message be revised to say label instead?
Activity
Abhishek01039 commentedon Oct 3, 2020
Hello @awhitford
Thanks for opening an issue.
I have created PR from your issue which you can check.
if you have any suggestions then please let me know
Thanks.
darshankawar commentedon Oct 5, 2020
Although the implementation does say to use
labelinstead, the concerned line could be updated.https://api.flutter.dev/flutter/widgets/BottomNavigationBarItem/BottomNavigationBarItem.html
[-][doc] BottomNavigationBarItem[/-][+][doc] BottomNavigationBarItem : Update title with label to reflect correct message. [/+]HansMuller commentedon Oct 5, 2020
CC @johnsonmh
Abhishek01039 commentedon Oct 10, 2020
Hi @awhitford
now you can close the issue because PR has been merged.
Now you can check here https://api.flutter.dev/flutter/widgets/BottomNavigationBarItem/BottomNavigationBarItem.html
Thanks
awhitford commentedon Oct 27, 2020
@Abhishek01039 The BottomNavigationBarItem doc still references
title(deprecated) instead oflabel.This issue does not look resolved to me.
github-actions commentedon Aug 10, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.