Several Flutter tools doesn't use Dart language versioning #70084

Activity

1. mit-mit

   changed the title [-]flutter updates-packages doesn't use Dart language versioning[/-] [+]Several Flutter tools doesn't use Dart language versioning[/+] on Nov 9, 2020
2. mit-mit commented on Nov 9, 2020

   

   mit-mit

   on Nov 9, 2020

   MemberAuthor

   More actions

   dev/tool/dartdoc.dart is another instance of this:

     // Create the pubspec.yaml file.
     final StringBuffer buf = StringBuffer();
     buf.writeln('name: $kDummyPackageName');
     buf.writeln('homepage: https://flutter.dev');
     // TODO(dnfield): Re-factor for proper versioning, https://github.com/flutter/flutter/issues/55409
     buf.writeln('version: 0.0.0');

   https://github.com/flutter/flutter/blob/master/dev/tools/dartdoc.dart#L53
3. pedromassangocode

   added

   passed first triage

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   on Nov 9, 2020
4. johnpryan commented on Nov 9, 2020

   

   johnpryan

   on Nov 9, 2020

   Contributor

   More actions

   I think this might be causing the doc generation script (dev/bots/docs.sh) to fail:

   output

   dartdoc:stderr: , from material.DataTable: (file:///Users/ryjohn/code/tmp/flutter/packages/flutter/lib/src/material/data_table.dart:384:7)
   dartdoc:stderr:   error: tool execution failed: Tool "snippet" returned non-zero exit code (64) when run as "/Users/ryjohn/code/tmp/flutter/bin/cache/dart-sdk/bin/dart /var/folders/3q/2gm34ftd37n43w9sxr09h0d000m6cw/T/dartdoc_snapshot_cache_WAZpHV/snapshot_0 --type=snippet" from /Users/ryjohn/code/tmp/flutter/dev/docs
   dartdoc:stderr: Input to snippet was:
   dartdoc:stderr:
   dartdoc:stderr: This sample creates a [MaterialApp] widget that stores `ThemeData` and
   dartdoc:stderr: passes the `ThemeData` to descendant widgets. The [AppBar] widget uses the
   dartdoc:stderr: [primaryColor] to create a blue background. The [Text] widget uses the
   dartdoc:stderr: [TextTheme.bodyText2] to create purple text. The [FloatingActionButton] widget
   dartdoc:stderr: uses the [accentColor] to create a green background.
   dartdoc:stderr:
   dartdoc:stderr: ![](https://flutter.github.io/assets-for-api-docs/assets/material/material_app_theme_data.png)
   dartdoc:stderr:
   dartdoc:stderr: ```dart
   dartdoc:stderr: MaterialApp(
   dartdoc:stderr:   theme: ThemeData(
   dartdoc:stderr:     primaryColor: Colors.blue,
   dartdoc:stderr:     accentColor: Colors.green,
   dartdoc:stderr:     textTheme: TextTheme(bodyText2: TextStyle(color: Colors.purple)),
   dartdoc:stderr:   ),
   dartdoc:stderr:   home: Scaffold(
   dartdoc:stderr:     appBar: AppBar(
   dartdoc:stderr:       title: const Text('ThemeData Demo'),
   dartdoc:stderr:     ),
   dartdoc:stderr:     floatingActionButton: FloatingActionButton(
   dartdoc:stderr:       child: const Icon(Icons.add),
   dartdoc:stderr:       onPressed: () {},
   dartdoc:stderr:     ),
   dartdoc:stderr:     body: Center(
   dartdoc:stderr:       child: Text(
   dartdoc:stderr:         'Button pressed 0 times',
   dartdoc:stderr:       ),
   dartdoc:stderr:     ),
   dartdoc:stderr:   ),
   dartdoc:stderr: )
   dartdoc:stderr: ```
   dartdoc:stderr: Stderr output was:
   dartdoc:stderr: Could not find an option named "type".
   dartdoc:stderr:
   dartdoc:stderr: Usage: dart [<vm-flags>] <command|dart-file> [<arguments>]
   dartdoc:stderr:
   dartdoc:stderr: Global options:
   dartdoc:stderr: -h, --help                 Print this usage information.
   dartdoc:stderr: -v, --verbose              Show additional command output.
   dartdoc:stderr:     --version              Print the Dart SDK version.
   dartdoc:stderr:     --enable-analytics     Enable anonymous analytics.
   dartdoc:stderr:     --disable-analytics    Disable anonymous analytics.
   dartdoc:stderr:
   dartdoc:stderr: Available commands:
   dartdoc:stderr:   analyze   Analyze the project's Dart code.
   dartdoc:stderr:   compile   Compile Dart to various formats.
   dartdoc:stderr:   create    Create a new project.
   dartdoc:stderr:   format    Idiomatically format Dart source code.
   dartdoc:stderr:   migrate   Perform a null safety migration on a project or package.
   dartdoc:stderr:   pub       Work with packages.
   dartdoc:stderr:   run       Run a Dart program.
   dartdoc:stderr:   test      Run tests in this package.
   dartdoc:stderr:
   dartdoc:stderr: Run "dart help <command>" for more information about a command.
   dartdoc:stderr: See https://dart.dev/tools/dart-tool for detailed documentation.
   
5. jmagman commented on Nov 10, 2020

   

   jmagman

   on Nov 10, 2020

   Member

   More actions

   I split the dartdoc request out to #70239 \cc @johnpryan. @jonahwilliams is looking into the flutter updates-packages piece.
6. jonahwilliams commented on Nov 11, 2020

   

   jonahwilliams

   on Nov 11, 2020

   Contributor

   More actions

   Looks like this one was fixed with 168ad5d, closing.

   Thanks @mit-mit !
7. jonahwilliams

   closed this as completedon Nov 11, 2020
8. github-actions commented on Aug 10, 2021

   

   github-actionsbot

   on Aug 10, 2021

   More actions

   This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
9. github-actions

   locked as resolved and limited conversation to collaborators on Aug 10, 2021