Skip to content

Add support for hover, add, and remove pointers #720

Closed
Closed
Add support for hover, add, and remove pointers#720
Labels
a: desktopRunning on desktopc: contributor-productivityTeam-specific productivity, code health, technical debt.c: new featureNothing broken; request for a new capabilitycustomer: fuchsiaplatform-fuchsiaFuchsia code specifically

Description

@Hixie
Hixie
opened on Dec 4, 2015
  • The "Pointer" struct doesn't represent a pointer, it represents a snapshot of pointer state. We should rename it to "PointerStateSnapshot" or "PointerData" or some such.
  • The "PointerPacket" class should then be renamed something like "PointerDataPacket" or something.
  • The "PointerType" enum should be renamed "PointerDisposition" or some such.
  • The "Pointer" struct should lose its "down" (redundant with the stream of events), "primary" (not going to be supported), and "distance_min" (always 0 by definition) fields.
  • We should implement all the fields on the Java side (distance, radius, orientation, tilt, and stylus/mouse aren't yet supported).
  • We should add add/remove notifications.
  • We should actually send add/remove notifications.
  • We should add support for hover pointers.
  • The service side should never send an "up" event that is moved away from where the last "move" event was. (Same for "cancel", and, if hover events are supported, "down".)

Activity

  1. Hixie
    added
    ⚠ bug
    c: new featureNothing broken; request for a new capability
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    affects: services
    on Dec 4, 2015
  2. Hixie
    added this to the milestone on Dec 4, 2015
  3. sethladd
    added
    c: API breakBackwards-incompatible API changes
    on Sep 20, 2016

  4. sethladd commented on Sep 20, 2016

    @sethladd
    sethladd
    on Sep 20, 2016
    Contributor

    Did we want to include this work in the "API stability" efforts?

  5. sethladd
    added
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Sep 20, 2016

  6. Hixie commented on Sep 20, 2016

    @Hixie
    Hixie
    on Sep 20, 2016
    ContributorAuthor

    Not sure. We have to do it eventually. Some of these changes are pretty low-level and many aren't critical for our near-term goals.

  7. Hixie
    removed
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Sep 20, 2016
  8. abarth
    self-assigned this
    on Sep 28, 2016

  9. abarth commented on Oct 16, 2016

    @abarth
    abarth
    on Oct 16, 2016
    Contributor

    I did a bunch of these, but there are more left to do. Unassigning.

  10. abarth
    removed their assignment
    on Oct 16, 2016
  11. abarth
    self-assigned this
    on Nov 15, 2016

  12. 11 remaining items

  13. abarth
    removed this from the milestone on Jan 26, 2017
  14. abarth
    changed the title [-]"Pointer" struct fixes[/-] [+]Add support for hover, add, and remove pointers[/+] on Jan 26, 2017
  15. abarth
    removed
    plugin
    on Jan 26, 2017
  16. abarth
    modified the milestones: , on Jan 26, 2017
  17. Hixie
    added
    platform-fuchsiaFuchsia code specifically
    on Jun 20, 2017
  18. Hixie
    added
    customer: fuchsia
    on Aug 15, 2017
  19. jslavitz
    self-assigned this
    on Sep 5, 2018

  20. zoechi commented on Dec 21, 2018

    @zoechi
    zoechi
    on Dec 21, 2018
    Contributor

    Related #5504

  21. gspencergoog
    added
    a: desktopRunning on desktop
    on Mar 20, 2019

  22. gspencergoog commented on Mar 20, 2019

    @gspencergoog
    gspencergoog
    on Mar 20, 2019
    Contributor

    I believe that all of these are addressed.

  23. gspencergoog
    closed this as completedon Mar 20, 2019
  24. Hixie
    unassigned
    jslavitz
    on Aug 17, 2020

  25. github-actions commented on Aug 16, 2021

    @github-actions
    github-actionsbot
    on Aug 16, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  26. github-actions
    locked as resolved and limited conversation to collaborators on Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    a: desktopRunning on desktopc: contributor-productivityTeam-specific productivity, code health, technical debt.c: new featureNothing broken; request for a new capabilitycustomer: fuchsiaplatform-fuchsiaFuchsia code specifically

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions