Repository navigation
Material text selection menu overflow buttons should be full-width #72023
Description
Tapping in the empty space to the right of "Custom button 2" should hit the button. Currently, it has no effect.
To fix this:
- Make the buttons full-width by setting the min and max width in their layout to the full width of the menu (code).
- Align the text in the button to the left or right depending on the text direction.
Currently, TextButton always centers its child and can't align to the left or right.
Activity
justinmc commentedon Dec 10, 2020
I discussed with @HansMuller and it was suggested that we may want to make TextButton support a configurable alignment. That would make step 2 above much simpler to fix.
Roshan13046 commentedon Dec 17, 2020
I would like to work on this issue.
can I go ahead?
justinmc commentedon Dec 17, 2020
@Roshan13046 Please do, thank you! I've assigned you to this issue.
It seems like the right solution here is to do something like add an
alignmentparameter to TextButton.FYI This also came up again recently when I looked at implementing at MacOS-style context menu. It will also need TextButtons that can align their text to the left. #31955 (comment)
justinmc commentedon Jan 14, 2021
This isn't fixed with #73894, just unblocked. We'll need to use the alignment parameter on the TextSelectionToolbarTextButtons. Also we may need to get fancier with the layout. Really we need the parent to size itself to the largest intrinsic width of its children, and then all the children need to match that width.