Repository navigation
Suggestion: rename DestinationLabel to BottomNavigationBarItem (or similar) #7278
Description
DestinationLabel seems (?) to be a term used in the Material Design docs but when initially onboarding it can be confusing as a concept because they contain more than a simple label. In addition, the property for setting the items in the navbar is labels so it should probably be renamed to items.
DestinationLabel seems to be only used in the BottomNavigationBar but I'm not sure if there is a broader use case I'm missing.
Happy to do a PR if you need.
Activity
abarth commentedon Dec 16, 2016
/cc @Hixie
abarth commentedon Dec 16, 2016
@HansMuller
Hixie commentedon Dec 16, 2016
There was another thing we were going to use them for... Can't remember what though. :-)
HansMuller commentedon Dec 16, 2016
DestinationLabel and TabLabel are rather similar, however in the new version of tabs I'm working on, TabLabel isn't needed anymore. I agree that BottomNavigationBarItem is a more obvious name for the items in a BottomNavigationBar, despite the material design spec.
lukef commentedon Dec 16, 2016
I created a PR (#7281) for this if you want to review.
abarth commentedon Jan 4, 2017
Looks like this happened.
github-actions commentedon Sep 5, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.