Hot reload doesn't update assets #7302

Activity

1. Hixie

   added

   affects: dev experience

   t: hot reloadReloading code during "flutter run"Reloading code during "flutter run"

   c: new featureNothing broken; request for a new capabilityNothing broken; request for a new capability

   on Dec 22, 2016
2. Hixie

   removed

   old label "dev experience" (tell Hixie today if you don't want this label deleted)

   on Jan 22, 2017
3. Hixie

   added this to the 3: Make conferences happyThis milestone has been deleted milestone on Feb 27, 2017
4. johnmccutchan commented on Apr 20, 2017

   

   johnmccutchan

   on Apr 20, 2017

   Contributor

   More actions

   The issue here is:

   When the application first boots it is using assets and script sources pulled from the APK/IPA installation directory. When we reload we switch to script sources from a temporary directory but not the assets. On a hot-restart we also switch the asset directory.

   To fix this:

   1. Add a new service protocol RPC that tells the engine to look in a specific directory for assets. This is mostly implemented today by the existing _flutter.runInView RPC which takes an assetDirectory parameter.
   2. Send this RPC after the first reload.
   3. Make sure that any cached assets are evicted.
5. Hixie

   added

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   on May 23, 2017
6. a-siva

   assigned

   aam

   on Sep 28, 2017
7. a-siva commented on Sep 28, 2017

   

   a-siva

   on Sep 28, 2017

   Contributor

   More actions

   @aam does this change with the new incremental kernel generator implementation? Since the sources are not pushed we should be able to switch to the assets directory right.
8. aam commented on Nov 3, 2017

   

   aam

   on Nov 3, 2017

   Last edited by aam

   Member

   More actions

   I don't think it changes with IKG. We still want to explicitly switch assets directory on hot reload by sending an RPC request(_flutter.setAssetDirectory , for example?) to flutter engine. Currently, only RPC request that is sent on hot reload is to _reloadSources to Dart VM to pick up updated sources(or incremental kernel file).
9. aam commented on Nov 3, 2017

   

   aam

   on Nov 3, 2017

   Member

   More actions

   This can be address with #12872 and flutter-team-archive/engine#4323
10. Hixie commented on Dec 20, 2017

    

    Hixie

    on Dec 20, 2017

    ContributorAuthor

    More actions

    Leaving in current milestone since "make hot reload trustworthy" is a priority.
11. aam

    closed this as completedon Jan 5, 2018
12. github-actions commented on Sep 4, 2021

    

    github-actionsbot

    on Sep 4, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
13. github-actions

    locked as resolved and limited conversation to collaborators on Sep 4, 2021