Skip to content

Update engine script create_ios_framework to optionally take ARM simulator path #73066

Closed

Description

@jmagman

In preparation for an ARM simulator framework update create_ios_framework to replace --simulator-out-dir with --simulator-x86-out-dir and --simulator-arm64-out-dir. lipo the simulator frameworks together.

When that's done, update the recipe logic that calls this script to pass in --simulator-x86-out-dir.
When #64502 is ready, it will additionally pass in --simulator-arm64-out-dir.

Don't remove deprecated --simulator-out-dir until after the recipe is updated to avoid breaking changes.

Activity

  1. added
    platform-iosiOS applications specifically
    engineflutter/engine related. See also e: labels.
    on Dec 29, 2020
  2. self-assigned this
    on Dec 29, 2020
  3. added
    P2Important issues not at the top of the work list
    on Jan 5, 2021
  4. removed their assignment
    on Jan 29, 2021
  5. self-assigned this
    on Jan 29, 2021
  6. gw280 commented on Apr 12, 2021

    @gw280
    Contributor

    Quick update: the engine scripts are ready and mostly work (I just need to do a minor fix and re-land flutter-team-archive/buildroot#437), but there's an issue that needs to be resolved on CI before we can modify the recipes.

    In order to build for arm64 simulator, we need to use Xcode 12.0.0 or newer, and thus we can't use our own llvm. As a result, we can't use goma to build, which means the build takes longer. Adding a new arm64 simulator build step to the existing iOS builder hits the timeout ceiling and so the build fails.

    After speaking with @godofredoc and @CaseyHillers, it looks like they're working on refactoring the existing CI recipes to allow for these builds to be sharded out and have cross-dependencies, which we would need in order to add the arm64 simulator builds.

  7. gw280 commented on Jun 16, 2021

    @gw280
    Contributor

    Closing in favour of #84672 as the other work is all done/merged.

  8. github-actions commented on Jul 31, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. locked as resolved and limited conversation to collaborators on Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listengineflutter/engine related. See also e: labels.platform-host-armBuilding on an ARM-based platformplatform-iosiOS applications specifically

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions