Skip to content

Support Flutter for web from arm host by building dart2js artifact for arm64 host dart-sdk. #74928

Closed
flutter-team-archive/engine
#25312
Closed
Support Flutter for web from arm host by building dart2js artifact for arm64 host dart-sdk.#74928
flutter-team-archive/engine
#25312
Labels
P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.c: new featureNothing broken; request for a new capabilityteam-infraOwned by Infrastructure team

Description

@christopherfujino
christopherfujino
opened on Jan 28, 2021

Previously, the dart-sdk did not support building the dart2js snapshot for arm64 hosts tracking issue. However, this was fixed upstream in dart-lang/sdk@9866c06. Flutter's compiled arm64 sdk does not include this snapshot, but it should be possible to build it and include it in the cached artifacts the Flutter tool downloads, allowing arm64 linux host users to develop Flutter for web apps.

Activity

  1. christopherfujino
    added
    c: new featureNothing broken; request for a new capability
    team-infraOwned by Infrastructure team
    on Jan 28, 2021
  2. christopherfujino
    changed the title [-]Build and cache dart2js artifact for arm64 host dart-sdk.[/-] [+]Support Flutter for web from arm host by building dart2js artifact for arm64 host dart-sdk.[/+] on Jan 28, 2021
  3. pedromassangocode
    added
    passed first triage
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    on Jan 29, 2021

  4. HidenoriMatsubayashi commented on Feb 4, 2021

    @HidenoriMatsubayashi
    HidenoriMatsubayashi
    on Feb 4, 2021
    Member

    dart2js will seem to be included in version 2.12 of dart-sdk. Currently, it’s still only in the 2.12-beta version.

  5. godofredoc
    added
    passed secondary triage
    P2Important issues not at the top of the work list
    on Feb 18, 2021

  6. HidenoriMatsubayashi commented on Mar 26, 2021

    @HidenoriMatsubayashi
    HidenoriMatsubayashi
    on Mar 26, 2021
    Member

    @christopherfujino
    Currently, version 2.12 in stable channel is released! See: https://dart.dev/tools/sdk/archive

  7. christopherfujino commented on Mar 29, 2021

    @christopherfujino
    christopherfujino
    on Mar 29, 2021
    ContributorAuthor

    @christopherfujino
    Currently, version 2.12 in stable channel is released! See: https://dart.dev/tools/sdk/archive

    Thanks! I haven't got a chance to circle back on this, but if you have some free time, I suspect the fix is a one-line gn build rule change to our engine repo.

  8. HidenoriMatsubayashi commented on Mar 30, 2021

    @HidenoriMatsubayashi
    HidenoriMatsubayashi
    on Mar 30, 2021
    Member

    If we leave it alone, will it be incorporated into the engine repo automatically eventually? If not, I'll fix it.

    Besides, gn build script maybe need to be modified to cross-build dart2js/dev_compiler for ARM64.

  9. christopherfujino commented on Mar 30, 2021

    @christopherfujino
    christopherfujino
    on Mar 30, 2021
    ContributorAuthor

    If we leave it alone, will it be incorporated into the engine repo automatically eventually? If not, I'll fix it.

    I think I figured this out, I'll prepare a PR...

  10. HidenoriMatsubayashi commented on Mar 30, 2021

    @HidenoriMatsubayashi
    HidenoriMatsubayashi
    on Mar 30, 2021
    Member

    Thank you so much!

  11. fluttergithubbot
    closed this as completedin flutter-team-archive/engine#25312on Mar 31, 2021

  12. christopherfujino commented on Apr 3, 2021

    @christopherfujino
    christopherfujino
    on Apr 3, 2021
    ContributorAuthor

    Confirmed building for web from ARM64 host works as of framework commit 824b1ad3f8.

  13. github-actions commented on Aug 3, 2021

    @github-actions
    github-actionsbot
    on Aug 3, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  14. github-actions
    locked as resolved and limited conversation to collaborators on Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.c: new featureNothing broken; request for a new capabilityteam-infraOwned by Infrastructure team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions