Let RenderEditable use LineMetrics instead of assuming every line has the same height

flutter/packages/flutter/lib/src/rendering/editable.dart

Lines 864 to 873 in 02d441e

    
           // The caret offset gives a location in the upper left hand corner of 
        
           // the caret so the middle of the line above is a half line above that 
        
           // point and the line below is 1.5 lines below that point. 
        
           final double preferredLineHeight = _textPainter.preferredLineHeight; 
        
           final double verticalOffset = upArrow ? -0.5 * preferredLineHeight : 1.5 * preferredLineHeight; 
        
           final Offset caretOffset = _textPainter.getOffsetForCaret(TextPosition(offset: newSelection.extentOffset), _caretPrototype); 
        
           final Offset caretOffsetTranslated = caretOffset.translate(0.0, verticalOffset); 
        
           final TextPosition position = _textPainter.getPositionForOffset(caretOffsetTranslated);

Vertical key movements may skip a line if that line is way shorter than its adjacent lines.

Additionally in a left-aligned text field:

aaaaaaa|
aaa
aaaaaaaaaa

pressing ↓ once should move the caret to the end of the second line:

aaaaaaa
aaa|
aaaaaaaaaa

press ↓ again should move the caret to the 3rd line, but further to the right:

aaaaaaa
aaa
aaaaaaa|aaa

Move text editing `Action`s to `EditableTextState`

Navigation Menu

Repository navigation

Let RenderEditable use LineMetrics instead of assuming every line has the same height #75572

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// The caret offset gives a location in the upper left hand corner of
	// the caret so the middle of the line above is a half line above that
	// point and the line below is 1.5 lines below that point.
	final double preferredLineHeight = _textPainter.preferredLineHeight;
	final double verticalOffset = upArrow ? -0.5 * preferredLineHeight : 1.5 * preferredLineHeight;

	final Offset caretOffset = _textPainter.getOffsetForCaret(TextPosition(offset: newSelection.extentOffset), _caretPrototype);
	final Offset caretOffsetTranslated = caretOffset.translate(0.0, verticalOffset);
	final TextPosition position = _textPainter.getPositionForOffset(caretOffsetTranslated);

Let RenderEditable use LineMetrics instead of assuming every line has the same height #75572

Description

Activity

LongCatIsLooong commented on Sep 20, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions