Skip to content

Make analysis_options in flutter/plugins much stricter #76229

Closed

Description

@stuartmorgan-g

Currently the flutter/plugins analysis_options.yaml is essentially just https://github.com/google/pedantic/blob/master/lib/analysis_options.1.8.0.yaml. Ideally we should be using all (or at the very least most) of the same options as flutter/flutter.

We'd need to figure out how to introduce these it a way that wouldn't be incredibly disruptive to all future incremental changes. Likely turning them on one by one in conjunction with repo-wide fixes for everything they turn up (one PR per lint option if there are widespread changes).

Activity

  1. added
    P3Issues that are less important to the Flutter project
    on Feb 18, 2021
  2. removed
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Feb 24, 2021
  3. stuartmorgan-g commented on Mar 11, 2021

    @stuartmorgan-g
    ContributorAuthor

    To get a sense of the scale of the issue, I dropped flutter/flutter's options into the plugins repo; the result is about 5,000 issues. Even going option by option, there are some options with many hundreds of instances (e.g., preferring single quoted strings was ~800).

    Instead I think we'll need to this plugin by plugin (and for large plugins, maybe even option by option within the plugin). That will also make it easier to deal with versioning/changelogs, since some changes may be potentially behavioral and thus require publishing.

  4. 48 remaining items

  5. github-actions commented on Mar 4, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.packageflutter/packages repository. See also p: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions