Skip to content

EditableText calls onSelectionChanged even if the selection does not change. #76349

Open
#87971
Open
EditableText calls onSelectionChanged even if the selection does not change.#76349
#87971
Labels
P2Important issues not at the top of the work lista: text inputEntering text in a text field or keyboard related problemsc: tech-debtTechnical debt, code quality, testing, etc.p: material_uimaterial_ui package in flutter/packagespackageflutter/packages repository. See also p: labels.team-text-inputOwned by Text Input teamtriaged-text-inputTriaged by Text Input team

Description

@chunhtai
chunhtai
opened on Feb 19, 2021

If you add a print statement in this method

flutter/packages/flutter/lib/src/material/text_field.dart

Line 1070 in 934dfde

void _handleSelectionChanged(TextSelection selection, SelectionChangedCause? cause) {

long press the textfield, you will see the print statement even if text selection does not change. This behavior is contradicted to the EditableText.onSelectionChange contract. Unfortunately, this is needed because textfield relies on this call to update the handle visibility.

We should fix this by refactoring out selection overlay of editable text so that text field does not need to rely on this callback, and then we should finally able to fix the EditableText.onSelectionChanged.

Activity

  1. pedromassangocode
    added
    a: text inputEntering text in a text field or keyboard related problems
    p: material_uimaterial_ui package in flutter/packages
    frameworkflutter/packages/flutter repository. See also f: labels.
    passed first triage
    c: tech-debtTechnical debt, code quality, testing, etc.
    on Feb 19, 2021
  2. fluttergithubbot
    closed this as completedin #87971on Aug 13, 2021

  3. github-actions commented on Aug 27, 2021

    @github-actions
    github-actionsbot
    on Aug 27, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  4. github-actions
    locked as resolved and limited conversation to collaborators on Aug 27, 2021
  5. Renzo-Olivares
    reopened this on May 14, 2025

  6. Renzo-Olivares commented on May 14, 2025

    @Renzo-Olivares
    Renzo-Olivares
    on May 14, 2025
    Contributor

    Re-opened this since #87971 was reverted in #88183 and the TODO still exists in the framework. I also verified this issue is still reproducible on master by following the instructions in the issue description.

  7. darshankawar
    added
    team-designOwned by Design Languages team
    on May 15, 2025
  8. justinmc
    added
    P2Important issues not at the top of the work list
    team-text-inputOwned by Text Input team
    triaged-text-inputTriaged by Text Input team
    and removed
    team-designOwned by Design Languages team
    on May 15, 2025
  9. flutter-triage-bot
    unlocked this conversation on May 16, 2025
  10. Piinks
    added
    packageflutter/packages repository. See also p: labels.
    and removed
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: text inputEntering text in a text field or keyboard related problemsc: tech-debtTechnical debt, code quality, testing, etc.p: material_uimaterial_ui package in flutter/packagespackageflutter/packages repository. See also p: labels.team-text-inputOwned by Text Input teamtriaged-text-inputTriaged by Text Input team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions