Skip to content

add GlowlessScrollBehavior #76490

Closed

Description

@nt4f04uNd

it would be a handly class to easily disable scroll glow without need for searching up "disable scroll glow flutter", which is by the way a very popular question on SO https://stackoverflow.com/questions/51119795/how-to-remove-scroll-glow

Activity

  1. added
    in triagePresently being triaged by the triage team
    f: scrollingViewports, list views, slivers, etc.
    frameworkflutter/packages/flutter repository. See also f: labels.
    c: proposalA detailed proposal for a change to Flutter
    and removed
    in triagePresently being triaged by the triage team
    on Feb 22, 2021
  2. HansMuller commented on Feb 22, 2021

    @HansMuller
    Contributor
  3. Piinks commented on Feb 22, 2021

    @Piinks
    Contributor

    Hey @nt4f04uNd I agree, we should make this easier. I am currently working on overhauling default ScrollBehaviors (related to #40107 and #71322), and can include this in that work to make this a better experience.

  4. self-assigned this
    on Feb 22, 2021
  5. Piinks commented on Feb 26, 2021

    @Piinks
    Contributor

    Hey @nt4f04uNd here is the proposal I mentioned: Design Document

  6. nt4f04uNd commented on Feb 26, 2021

    @nt4f04uNd
    MemberAuthor

    @Piinks i read it and overall i like the idea of exposing the ScrollBehaviors. one thing i would like to clarify: do you think adding scrollBehavior into the app widget sufficient? it helps to discover the ScrollBehavior, but then you still need to extend it and override the buildViewportChrome to disable it, which is pretty common, so GlowlessScrollBehavior still makes sense

    by the way it could be MaterialScrollBehavior.glowless(), or MaterialScrollBehavior(glow: false)

    this is of course unless you have some thoughts on how to make it even more easy

  7. Piinks commented on Feb 26, 2021

    @Piinks
    Contributor

    @Piinks i read it and overall i like the idea of exposing the ScrollBehaviors. one thing i would like to clarify: do you think adding scrollBehavior into the app widget sufficient? it helps to discover the ScrollBehavior, but then you still need to extend it and override the buildViewportChrome to disable it, which is pretty common, so GlowlessScrollBehavior still makes sense

    by the way it could be MaterialScrollBehavior.glowless(), or MaterialScrollBehavior(glow: false)

    this is of course unless you have some thoughts on how to make it even more easy

    Interesting ideas! The design document is meant just for discussing options like these. Could you add these as comments on the doc? We'll be collecting feedback over the next few days there and I would hate for it to be left out.

    You should have comment permissions, let me know if that is not the case.

  8. nt4f04uNd commented on Feb 26, 2021

    @nt4f04uNd
    MemberAuthor

    @Piinks added

  9. Piinks commented on Mar 11, 2021

    @Piinks
    Contributor

    I do not think we will be adding this type of ScrollBehavior or adding it as a constructor of MaterialScrollBehavior. As https://github.com/flutter/flutter/pull/76494/files shows, it is a very minimal amount of code to remove the glow with your own ScrollBehavior. #76739 will expose ScrollBehaviors that were previously private, making them more available for users to extend, modify and build on. This change also adds the ability to set the ScrollBehavior at the app-level, where before is was not available to change the default. :)

  10. nt4f04uNd commented on Mar 11, 2021

    @nt4f04uNd
    MemberAuthor

    oops didn't mean to

  11. nt4f04uNd commented on Mar 11, 2021

    @nt4f04uNd
    MemberAuthor
  12. github-actions commented on Aug 4, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  13. locked as resolved and limited conversation to collaborators on Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: proposalA detailed proposal for a change to Flutterf: scrollingViewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.r: solvedIssue is closed as solved

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions