Skip to content

Linux "flutter/generated_plugin_registrant.{h,cc}" are checked into source control, building generates "// clang-format off" #76726

Open
Open
Linux "flutter/generated_plugin_registrant.{h,cc}" are checked into source control, building generates "// clang-format off"#76726
Labels
P2Important issues not at the top of the work lista: desktopRunning on desktopplatform-linuxBuilding on or for Linux specificallyteam-linuxOwned by the Linux platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-linuxTriaged by the Linux platform team

Description

@jmagman
jmagman
opened on Feb 24, 2021

I vaguely remember having a conversation with @stuartmorgan about why this file isn't in the ephemeral directory but I can't recall the details.

Either it should be generated in the ephemeral directory so it's not checked into source control, or if it is supposed to be checked into source control, all the generated_plugin_registrant files checked in the Flutter repo should be updated to have // clang-format off so we don't get a dirty working copy every time we build an example or integration test app.
#76662

diff --git a/dev/integration_tests/flutter_gallery/linux/flutter/generated_plugin_registrant.cc b/dev/integration_tests/flutter_gallery/linux/flutter/generated_plugin_registrant.cc
index 026851fa2f..f6f23bfe97 100644
--- a/dev/integration_tests/flutter_gallery/linux/flutter/generated_plugin_registrant.cc
+++ b/dev/integration_tests/flutter_gallery/linux/flutter/generated_plugin_registrant.cc
@@ -2,6 +2,8 @@
 //  Generated file. Do not edit.
 //
 
+// clang-format off
+
 #include "generated_plugin_registrant.h"
 
 #include <url_launcher_linux/url_launcher_plugin.h>

Activity

  1. jmagman
    added
    toolAffects the "flutter" command-line tool. See also t: labels.
    platform-windowsBuilding on or for Windows specifically
    platform-linuxBuilding on or for Linux specifically
    a: desktopRunning on desktop
    on Feb 24, 2021

  2. jmagman commented on Feb 24, 2021

    @jmagman
    jmagman
    on Feb 24, 2021
    MemberAuthor

    \cc @blasten

  3. stuartmorgan-g commented on Feb 24, 2021

    @stuartmorgan-g
    stuartmorgan-g
    on Feb 24, 2021
    Contributor

    I vaguely remember having a conversation with @stuartmorgan about why this file isn't in the ephemeral directory but I can't recall the details.

    Luckily it was in a persisted medium :) #71762

    The tl;dr is "because everyone else was doing it"

  4. jmagman commented on Feb 24, 2021

    @jmagman
    jmagman
    on Feb 24, 2021
    MemberAuthor

    Luckily it was in a persisted medium :) #71762

    You're a GitHub search sorcerer.

  5. pedromassangocode
    added
    passed first triage
    on Feb 25, 2021
  6. gspencergoog
    added
    P2Important issues not at the top of the work list
    on Feb 25, 2021
  7. flutter-triage-bot
    added
    multiteam-retriage-candidate
    team-desktop
    triaged-desktop
    on Jul 7, 2023
  8. Hixie
    removed
    passed first triage
    on Jul 8, 2023
  9. Hixie
    removed
    multiteam-retriage-candidate
    on Mar 6, 2024
  10. cbracken
    added
    team-linuxOwned by the Linux platform team
    on Jun 6, 2024

  11. 12 remaining items

  12. stuartmorgan-g
    changed the title [-]Desktop generated plugin registrants are checked into source control, building generates "// clang-format off"[/-] [+]Linux "flutter/generated_plugin_registrant.{h,cc}" are checked into source control, building generates "// clang-format off"[/+] on Jun 7, 2024
  13. stuartmorgan-g
    added
    team-linuxOwned by the Linux platform team
    triaged-linuxTriaged by the Linux platform team
    and removed
    platform-windowsBuilding on or for Windows specifically
    team-toolOwned by Flutter Tool team
    triaged-toolTriaged by Flutter Tool team
    platform-macosBuilding on or for macOS specifically
    on Jun 7, 2024

  14. stuartmorgan-g commented on Jun 7, 2024

    @stuartmorgan-g
    stuartmorgan-g
    on Jun 7, 2024
    Contributor

    I was going to merge these into one for desktop, but on second thought since the codepaths are all different and we already have a separate one for macOS, I'll file a new one for Windows instead.

  15. lishaduck
    added 4 commits that reference this issue on Mar 23, 2025

    chore: mark ephemeral files as generated

    f36d23f

    chore: mark ephemeral files as generated

    74a544b

    chore: mark ephemeral files as generated

    6b25a72

    chore: mark ephemeral files as generated

    1432938
  16. github-merge-queue
    added a commit that references this issue on Apr 6, 2025

    Further UI Improvements (#155)

    21dc464
  17. auto-submit
    added a commit that references this issue on Apr 7, 2026

    [various] Ignore generated plugin files (#11455)

    0e0a032
  18. creatorpiyush
    added a commit that references this issue on Jun 10, 2026

    [various] Ignore generated plugin files (flutter#11455)

    8929c91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: desktopRunning on desktopplatform-linuxBuilding on or for Linux specificallyteam-linuxOwned by the Linux platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-linuxTriaged by the Linux platform team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions