Make sure Scrollable.ensureVisible works with children before the center #7919

Activity

1. abarth

   added

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   on Feb 7, 2017
2. abarth

   self-assigned this

   on Feb 7, 2017
3. abarth

   added

   f: scrollingViewports, list views, slivers, etc.Viewports, list views, slivers, etc.

   on Feb 21, 2017
4. abarth

   removed their assignment

   on Feb 22, 2017
5. abarth

   added this to the 5: Make Hixie proudThis milestone has been deleted milestone on Feb 22, 2017
6. Hixie

   modified the milestones: 4: Make shippers happyThis milestone has been deleted, 5: Make Hixie proudThis milestone has been deleted on Feb 28, 2017
7. Hixie

   changed the title [-]Make sure Scrollable2.ensureVisible works with children before the center[/-] [+]Make sure Scrollable.ensureVisible works with children before the center[/+] on Jul 24, 2018
8. kf6gpe

   added

   P2Important issues not at the top of the work listImportant issues not at the top of the work list

   on May 29, 2020
9. kf6gpe

   removed this from the GoalsThis milestone has been deleted milestone on Jun 2, 2020
10. Hixie

    removed this from the GoalsThis milestone has been deleted milestone on Jun 2, 2020
11. Hixie

    removed this from the None.This milestone has been deleted milestone on Aug 17, 2020
12. pedromassangocode commented on Aug 27, 2020

    

    pedromassangocode

    on Aug 27, 2020

    More actions

    This still reproducible on latest master channel since the test case is still being skipped and the TODO is still there.
    

    flutter/packages/flutter/test/widgets/ensure_visible_test.dart

    Lines 374 to 431 in f35a8b7

    	// TODO(abarth): Unskip this test. See https://github.com/flutter/flutter/issues/7919
    	testWidgets('ListView ensureVisible negative child', (WidgetTester tester) async {
    	BuildContext findContext(int i) => tester.element(findKey(i));
    	Future<void> prepare(double offset) async {
    	tester.state<ScrollableState>(find.byType(Scrollable)).position.jumpTo(offset);
    	await tester.pump();
    	}
    	double getOffset() {
    	return tester.state<ScrollableState>(find.byType(Scrollable)).position.pixels;
    	}
    	Widget buildSliver(int i) {
    	return SliverToBoxAdapter(
    	key: ValueKey<int>(i),
    	child: const SizedBox(width: 200.0, height: 200.0),
    	);
    	}
    	await tester.pumpWidget(
    	Directionality(
    	textDirection: TextDirection.ltr,
    	child: Center(
    	child: SizedBox(
    	width: 600.0,
    	height: 400.0,
    	child: Scrollable(
    	viewportBuilder: (BuildContext context, ViewportOffset offset) {
    	return Viewport(
    	offset: offset,
    	center: const ValueKey<int>(4),
    	slivers: <Widget>[
    	buildSliver(0),
    	buildSliver(1),
    	buildSliver(2),
    	buildSliver(3),
    	buildSliver(4),
    	buildSliver(5),
    	buildSliver(6),
    	],
    	);
    	},
    	),
    	),
    	),
    	),
    	);
    	await prepare(-125.0);
    	Scrollable.ensureVisible(findContext(3));
    	await tester.pump();
    	expect(getOffset(), equals(-200.0));
    	await prepare(-225.0);
    	Scrollable.ensureVisible(findContext(2));
    	await tester.pump();
    	expect(getOffset(), equals(-400.0));
    	}, skip: true); // https://github.com/flutter/flutter/issues/7919
13. pedromassangocode

    added

    found in release: 1.22Found to occur in 1.22Found to occur in 1.22

    has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work on

    a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our tests

    on Aug 27, 2020
14. xu-baolin

    self-assigned this

    on Jan 8, 2021
15. fluttergithubbot

    closed this as completedin #73545on Jan 13, 2021
16. github-actions commented on Aug 7, 2021

    

    github-actionsbot

    on Aug 7, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
17. github-actions

    locked as resolved and limited conversation to collaborators on Aug 7, 2021