Skip to content

RenderEditable should not show the caret when the selection is invalid (i.e. (-1, -1)) #79495

Description

@LongCatIsLooong

This corresponds to a TODO item:

// TODO(LongCatIsLooong): skip painting the caret when the selection is
// (-1, -1).
if (selection == null || !selection.isCollapsed)
return;

Activity

  1. added
    a: text inputEntering text in a text field or keyboard related problems
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Mar 31, 2021
  2. LongCatIsLooong commented on Apr 1, 2021

    @LongCatIsLooong
    ContributorAuthor

    Related to #79494: a few tests failed because they're calling enterText, which currently sets the selection to (-1, -1), and with the change the caret will no longer be painted.

  3. github-actions commented on Aug 2, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  4. locked as resolved and limited conversation to collaborators on Aug 2, 2021
  5. gnprice commented on Mar 21, 2023

    @gnprice
    Member

    #79607 was reverted (in #81076), so reopening.

  6. added
    P2Important issues not at the top of the work list
    on Mar 21, 2023
  7. unlocked this conversation on Jun 16, 2023
  8. github-actions commented on Mar 2, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. locked as resolved and limited conversation to collaborators on Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P2Important issues not at the top of the work lista: text inputEntering text in a text field or keyboard related problemsframeworkflutter/packages/flutter repository. See also f: labels.team-frameworkOwned by Framework teamtriaged-frameworkTriaged by Framework team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions