Skip to content

Remove "--dump-skp-on-shader-compilation" and all related code in engine and tool #80091

Closed
#162849
Closed
Remove "--dump-skp-on-shader-compilation" and all related code in engine and tool#80091
#162849
Labels
P3Issues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-engineTriaged by Engine team

Description

@Hixie
Hixie
opened on Apr 9, 2021

We implemented --dump-skp-on-shader-compilation for customer: dream. Once they stop using it, we should remove it from our codebase, because as implemented it is essentially unusable. There's no documentation, and it is entirely unintuitive how to actually obtain the files to which it refers.

We may in due course want to create other mechanisms e.g. to save the SKPs for expensive frames from the DevTools, or similar, but that is a separate issue.

Activity

  1. Hixie
    added
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    toolAffects the "flutter" command-line tool. See also t: labels.
    engineflutter/engine related. See also e: labels.
    P3Issues that are less important to the Flutter project
    on Apr 9, 2021
  2. darshankawar
    added
    passed first triage
    on Apr 14, 2021

  3. jmagman commented on Apr 15, 2021

    @jmagman
    jmagman
    on Apr 15, 2021
    Member

    @Hixie is there a tracking issue somewhere for them removing it? I only see it referenced in third_party right now, unless I'm missing it.

  4. Hixie commented on Apr 15, 2021

    @Hixie
    Hixie
    on Apr 15, 2021
    ContributorAuthor

    I have no idea if they plan to stop using it. Eventually, though, it will become unnecessary because we won't need shader warmup, at which point we can ask them to remove it, then this will become relevant.

  5. flutter-triage-bot
    added
    multiteam-retriage-candidate
    team-engineOwned by Engine team
    triaged-engineTriaged by Engine team
    on Jul 8, 2023
  6. Hixie
    removed
    passed first triage
    on Jul 8, 2023
  7. Hixie
    removed
    multiteam-retriage-candidate
    on Mar 6, 2024
  8. github-merge-queue
    added a commit that references this issue on Feb 10, 2025

    [flutter_tools] remove SkSL bundling and dump skp on compilation. (#1…

    33a4c95
  9. auto-submit
    closed this as completedin #162849on Feb 10, 2025

  10. github-actions commented on Feb 24, 2025

    @github-actions
    github-actionsbot
    on Feb 24, 2025 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  11. github-actions
    locked as resolved and limited conversation to collaborators on Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions