Repository navigation
pkg:pigeon and pkg:flutter_markdown fail publishable check #82368
Description
pkg:flutter_markdown
* 1 checked in file are ignored by a `.gitignore`.
Previous versions of Pub would include those in the published package.
Consider adjusting your `.gitignore` files to not ignore those files, and if you do not wish to
publish these files use `.pubignore`. See also dart.dev/go/pubignore
Files that are checked in while gitignored:
flutter_markdown.iml
pkg:pigeon
* 4 checked in files are ignored by a `.gitignore`.
Previous versions of Pub would include those in the published package.
Consider adjusting your `.gitignore` files to not ignore those files, and if you do not wish to
publish these files use `.pubignore`. See also dart.dev/go/pubignore
Files that are checked in while gitignored:
ci/.gitignore
e2e_tests/test_objc/ios/Flutter/AppFrameworkInfo.plist
e2e_tests/test_objc/ios/Flutter/Debug.xcconfig
e2e_tests/test_objc/ios/Flutter/Release.xcconfig
This is keeping the flutter/packages tree red: https://cirrus-ci.com/task/6592972780208128?logs=publishable#L1337
Activity
goderbauer commentedon May 12, 2021
@gaaclarke for pigeon
@stuartmorgan and @domesticmouse for flutter_markdown
Prepare flutter_lints for 1.0 release (#349)
stuartmorgan-g commentedon May 12, 2021
Looks like a new warning. I'll do an audit of the repo's .gitignore since I'm not sure all of those should be ignored.
stuartmorgan-g commentedon May 12, 2021
The issues are both local to the packages.
flutter_markdownjust needs that file removed.@gaaclarke why does
pigeonhavee2e_tests/test_objc/ios/Flutter/in its gitignore? Are you generating the app on the fly each time it's run or something? If not, that directory shouldn't be ignored, only the generated files in it. For some reason the test app doesn't have the template-generated .gitignore that would handle things like this correctly.[flutter_markdown] Remove ignored file
gaaclarke commentedon May 12, 2021
@stuartmorgan if I recall correctly, it was done to ignore the App.framework which is regenerated. I'll clean it up.
gaaclarke commentedon May 12, 2021
I'm having a hard time verifying the results locally:
I upgraded my
flutter_plugin_toolsbut no luckgaaclarke commentedon May 12, 2021
I think
pub publish --dry-runwithout warnings should catch it (assuming I have the right version of dart).stuartmorgan-g commentedon May 12, 2021
What version did it say you were activating?
But yes,
pub publish --dry-runis pretty much all that's doing.gaaclarke commentedon May 12, 2021
I did this
dart pub global activate --source git https://github.com/flutter/plugin_tools.githoping it would get the latest, it got0.0.45+3.[flutter_markdown] Remove ignored file (#351)
stuartmorgan-g commentedon May 12, 2021
That repo is discontinued; the source moved to flutter/plugins because it's much harder to maintain out-of-repo (relative to most of its use; flutter/packages is a subset, and has far fewer PRs). You want
dart pub global activate flutter_plugin_tools.stuartmorgan-g commentedon May 13, 2021
Fixed by the PRs above.
github-actions commentedon Aug 1, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.