Skip to content

Remove dependence of metrics_center on package:equatable #83100

Closed
flutter/packages
#4444
Closed
Remove dependence of metrics_center on package:equatable#83100
flutter/packages
#4444
Assignees
Hixie
Labels
P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine teamwaiting for PR to land (fixed)A fix is in flight

Description

@zanderso
zanderso
opened on May 21, 2021

It is used only here https://github.com/flutter/packages/blob/master/packages/metrics_center/lib/src/common.dart#L16, and that usage could be replaced with straightforward == and hashCode methods.

Removing the dependence would allow including fewer Dart packages in the engine DEPS file: https://github.com/flutter/engine/blob/master/DEPS#L397

Activity

  1. zanderso
    added
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    easy fix
    engineflutter/engine related. See also e: labels.
    P2Important issues not at the top of the work list
    on May 21, 2021

  2. SirusCodes commented on May 26, 2021

    @SirusCodes
    SirusCodes
    on May 26, 2021
    Contributor

    Removing equatable will require us to add meta for immutable annotation.

    So effectively we re getting rid of only collections, should I make a PR? @zanderso ?

  3. flutter-triage-bot
    added
    team-engineOwned by Engine team
    triaged-engineTriaged by Engine team
    on Jul 8, 2023
  4. Hixie
    self-assigned this
    on Jul 11, 2023
  5. Hixie
    added
    waiting for PR to land (fixed)A fix is in flight
    on Jul 11, 2023
  6. auto-submit
    closed this as completedin packages#4444on Jul 12, 2023
  7. auto-submit
    added a commit that references this issue on Jul 12, 2023

    [metrics_center] Remove Equatable dependency (#4444)

    7438c0b

  8. github-actions commented on Jul 26, 2023

    @github-actions
    github-actionsbot
    on Jul 26, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. github-actions
    locked as resolved and limited conversation to collaborators on Jul 26, 2023
  10. creatorpiyush
    added a commit that references this issue on Jun 10, 2026

    [metrics_center] Remove Equatable dependency (flutter#4444)

    81f87be
  11. bisor0627
    added a commit that references this issue on Jun 19, 2026

    [metrics_center] Remove Equatable dependency (flutter#4444)

    54160df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine teamwaiting for PR to land (fixed)A fix is in flight

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions