Skip to content

Would like to be able to peek next and previous pages in addition to current #8408

Closed

Description

@eseidelGoogle

Activity

  1. abarth commented on Feb 25, 2017

    @abarth
    Contributor

    We need to teach RenderSliverFill to deflate the viewport dimension by the "peek" amount when sizing its children and then also factor the "peek" amount into _PagePosition's logic for converting scroll offsets to page numbers.

  2. self-assigned this
    on Feb 26, 2017
  3. abarth commented on Feb 26, 2017

    @abarth
    Contributor

    Work in progress: https://github.com/abarth/flutter/tree/page_peek. Still need to work out the PageController aspects.

  4. lukef commented on Feb 26, 2017

    @lukef
    Contributor

    I'll pull down the WIP later tonight and give it a go.

  5. abarth commented on Feb 27, 2017

    @abarth
    Contributor

    It's a little subtle. Basically, all the places in https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/widgets/page_view.dart that divide by viewportDimension need to take the peek value into account.

    The subtle issue is make sure they call get the updated peek value if the PageView rebuilds with a different value. We probably need to change shouldUpdatePosition in Scrollable to let the ScrollController recreate the ScrollPosition in more cases. (Needs a bit more study to find the best path.)

  6. abarth commented on Mar 2, 2017

    @abarth
    Contributor

    Made some progress. Still not quite right, but getting close.

  7. lukef commented on Mar 2, 2017

    @lukef
    Contributor

    @abarth - Let me know if you need feedback or information!

  8. added a commit that references this issue on Mar 3, 2017
    0403ed4
  9. github-actions commented on Sep 5, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  10. locked as resolved and limited conversation to collaborators on Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions