Skip to content

Web hot restart tests flaky timeout frequently causing web_tool_tests failure #85043

Closed

Description

@zanderso

Activity

  1. added
    a: tests"flutter test", flutter_test, or one of our tests
    platform-webWeb applications specifically
    c: disabled testTracks the restoration of a disabled test
    on Jun 22, 2021
  2. zanderso commented on Jun 22, 2021

    @zanderso
    MemberAuthor
  3. added
    toolAffects the "flutter" command-line tool. See also t: labels.
    on Jun 22, 2021
  4. changed the title [-]We hot restart test flaky timeout frequently on Windows/canvaskit[/-] [+]We hot restart test flaky timeout frequently on Windows/canvaskit, causing `Windows web_tool_tests` 2.74% flaky[/+] on Jun 22, 2021
  5. added
    c: flakeTests that sometimes, but not always, incorrectly pass
    on Jun 22, 2021
  6. jonahwilliams commented on Jun 25, 2021

    @jonahwilliams
    Contributor

    looking in the logs I see some canvaskit errors. ill switch the apps to use html

  7. changed the title [-]We hot restart test flaky timeout frequently on Windows/canvaskit, causing `Windows web_tool_tests` 2.74% flaky[/-] [+]Web hot restart test flaky timeout frequently on Windows causing `Windows web_tool_tests` 2.74% flaky[/+] on Jun 30, 2021
  8. 28 remaining items

  9. fluttergithubbot commented on Aug 2, 2021

    @fluttergithubbot
    Contributor

    Current flaky ratio for the past 15 days is 0.56%.
    One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20web_tool_tests/2876
    Commit: c2f09e0
    Flaky builds:
    https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20web_tool_tests/2876

  10. fluttergithubbot commented on Aug 9, 2021

    @fluttergithubbot
    Contributor

    Current flaky ratio for the past 15 days is 0.00%.

  11. fluttergithubbot commented on Aug 16, 2021

    @fluttergithubbot
    Contributor

    Current flaky ratio for the past 15 days is 0.00%.

  12. fluttergithubbot commented on Aug 23, 2021

    @fluttergithubbot
    Contributor

    Current flaky ratio for the past 15 days is 0.76%.
    One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20web_tool_tests/3143
    Commit: 3216e9f
    Flaky builds:
    https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20web_tool_tests/3143

  13. annagrin commented on Aug 25, 2021

    @annagrin
    Contributor

    A new flake - looks like we are not retrying when connecting to a chrome tab:

    final ChromeTab chromeTab = await chrome.chromeConnection.getTab((ChromeTab chromeTab) {

    /cc @jonahwilliams I think we could just pass a retry: 5 or some number there?

  14. fluttergithubbot commented on Aug 30, 2021

    @fluttergithubbot
    Contributor

    Current flaky ratio for the past 15 days is 0.57%.
    One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20web_tool_tests/3143
    Commit: 3216e9f
    Flaky builds:
    https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20web_tool_tests/3143

  15. zanderso commented on Aug 30, 2021

    @zanderso
    MemberAuthor

    @annagrin I'm not sure @jonahwilliams is reading here anymore if that question was directed at him. If a retry there could succeed after an initial failure, then that sounds like something that could deflake the test.

  16. fluttergithubbot commented on Sep 6, 2021

    @fluttergithubbot
    Contributor

    Current flaky ratio for the past 15 days is 0.00%.

  17. annagrin commented on Sep 7, 2021

    @annagrin
    Contributor

    @zanderso I will add the retries to see if it has any effect, but it looks like the occurrences are pretty rare at the moment.

  18. fluttergithubbot commented on Sep 13, 2021

    @fluttergithubbot
    Contributor

    Current flaky ratio for the past 15 days is 0.00%.

  19. fluttergithubbot commented on Sep 20, 2021

    @fluttergithubbot
    Contributor

    Current flaky ratio for the past 15 days is 0.00%.

  20. annagrin commented on Sep 30, 2021

    @annagrin
    Contributor

    Closing this as there have been no flakiness for a month, please feel free to reopen if needed!

  21. github-actions commented on Oct 14, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  22. locked as resolved and limited conversation to collaborators on Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work lista: tests"flutter test", flutter_test, or one of our testsc: disabled testTracks the restoration of a disabled testc: flakeTests that sometimes, but not always, incorrectly passplatform-webWeb applications specificallytoolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions