You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Web hot restart tests flaky timeout frequently causing web_tool_tests failure #85043
changed the title [-]We hot restart test flaky timeout frequently on Windows/canvaskit[/-][+]We hot restart test flaky timeout frequently on Windows/canvaskit, causing `Windows web_tool_tests` 2.74% flaky[/+]on Jun 22, 2021
changed the title [-]We hot restart test flaky timeout frequently on Windows/canvaskit, causing `Windows web_tool_tests` 2.74% flaky[/-][+]Web hot restart test flaky timeout frequently on Windows causing `Windows web_tool_tests` 2.74% flaky[/+]on Jun 30, 2021
@annagrin I'm not sure @jonahwilliams is reading here anymore if that question was directed at him. If a retry there could succeed after an initial failure, then that sounds like something that could deflake the test.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
Skip a hot_reload_web_test on Windows
Update hot_reload_web_test.dart
zanderso commentedon Jun 22, 2021
@annagrin
Skip a flaky Windows/canvaskit test in hot_reload_web_test.dart (#85044)
[-]We hot restart test flaky timeout frequently on Windows/canvaskit[/-][+]We hot restart test flaky timeout frequently on Windows/canvaskit, causing `Windows web_tool_tests` 2.74% flaky[/+]alexmarkov commentedon Jun 23, 2021
test/web.shard/hot_reload_web_test.dartalso flaky times out on Linux on head-head-head bots:https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8843692410606035153/+/u/flutter_test_web_tool_tests/stdout
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8843646616757342784/+/u/flutter_test_tool_tests/stdout
jonahwilliams commentedon Jun 25, 2021
looking in the logs I see some canvaskit errors. ill switch the apps to use html
[-]We hot restart test flaky timeout frequently on Windows/canvaskit, causing `Windows web_tool_tests` 2.74% flaky[/-][+]Web hot restart test flaky timeout frequently on Windows causing `Windows web_tool_tests` 2.74% flaky[/+]28 remaining items
fluttergithubbot commentedon Aug 2, 2021
Current flaky ratio for the past 15 days is 0.56%.
One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20web_tool_tests/2876
Commit: c2f09e0
Flaky builds:
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20web_tool_tests/2876
fluttergithubbot commentedon Aug 9, 2021
Current flaky ratio for the past 15 days is 0.00%.
fluttergithubbot commentedon Aug 16, 2021
Current flaky ratio for the past 15 days is 0.00%.
fluttergithubbot commentedon Aug 23, 2021
Current flaky ratio for the past 15 days is 0.76%.
One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20web_tool_tests/3143
Commit: 3216e9f
Flaky builds:
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20web_tool_tests/3143
annagrin commentedon Aug 25, 2021
A new flake - looks like we are not retrying when connecting to a chrome tab:
flutter/packages/flutter_tools/lib/src/isolated/resident_web_runner.dart
Line 543 in 44d9af8
/cc @jonahwilliams I think we could just pass a
retry: 5or some number there?fluttergithubbot commentedon Aug 30, 2021
Current flaky ratio for the past 15 days is 0.57%.
One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20web_tool_tests/3143
Commit: 3216e9f
Flaky builds:
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20web_tool_tests/3143
zanderso commentedon Aug 30, 2021
@annagrin I'm not sure @jonahwilliams is reading here anymore if that question was directed at him. If a retry there could succeed after an initial failure, then that sounds like something that could deflake the test.
fluttergithubbot commentedon Sep 6, 2021
Current flaky ratio for the past 15 days is 0.00%.
annagrin commentedon Sep 7, 2021
@zanderso I will add the retries to see if it has any effect, but it looks like the occurrences are pretty rare at the moment.
fluttergithubbot commentedon Sep 13, 2021
Current flaky ratio for the past 15 days is 0.00%.
fluttergithubbot commentedon Sep 20, 2021
Current flaky ratio for the past 15 days is 0.00%.
annagrin commentedon Sep 30, 2021
Closing this as there have been no flakiness for a month, please feel free to reopen if needed!
github-actions commentedon Oct 14, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.