[Documentation] AppBarTheme toolbarTextStyle and titleTextStyle documentation not following the current behavior

The documentation says we need to enable backwardsCompatibility to use toolbarTextStyle and titleTextStyle, but I can only use them when I disable it.

I've made a repo with a piece of code to try the functionality: https://github.com/Charly6596/Title-text-style-issue

Screenshots

The fact that the documentation says that toolbarTextStyle is obsolete also confuses me.

flutter/packages/flutter/lib/src/material/app_bar_theme.dart

Line 157 in 456fe1a

/// Overrides the default value for the obsolete [AppBar.toolbarTextStyle]

By reading #71184 (comment) I assume that the documentation should be fixed and the behaviour is correct.

Also, the AppBar documentation isn't updated regarding to the backwardsCompatibility flag.

The current behaviour can be observed in the implementation:

flutter/packages/flutter/lib/src/material/app_bar.dart

Lines 836 to 850 in 7d707b0

    
           TextStyle? toolbarTextStyle = backwardsCompatibility 
        
             ? widget.textTheme?.bodyText2 
        
               ?? appBarTheme.textTheme?.bodyText2 
        
               ?? theme.primaryTextTheme.bodyText2 
        
             : widget.toolbarTextStyle 
        
               ?? appBarTheme.toolbarTextStyle 
        
               ?? theme.textTheme.bodyText2?.copyWith(color: foregroundColor); 
        
           TextStyle? titleTextStyle = backwardsCompatibility 
        
             ? widget.textTheme?.headline6 
        
               ?? appBarTheme.textTheme?.headline6 
        
               ?? theme.primaryTextTheme.headline6 
        
             : widget.titleTextStyle 
        
               ?? appBarTheme.titleTextStyle 
        
               ?? theme.textTheme.headline6?.copyWith(color: foregroundColor);

The fact that #81675 (comment) mentions that the value should be true to use titleTextStyle confused me, commenting it just so others can be redirected here if they had the same problem as the OP

You are correct and sorry about that. The fixed docs are about to land in #86198, along with a slew of other changes.

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

Navigation Menu

Repository navigation

[Documentation] AppBarTheme toolbarTextStyle and titleTextStyle documentation not following the current behavior #86127

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	TextStyle? toolbarTextStyle = backwardsCompatibility
	? widget.textTheme?.bodyText2
	?? appBarTheme.textTheme?.bodyText2
	?? theme.primaryTextTheme.bodyText2
	: widget.toolbarTextStyle
	?? appBarTheme.toolbarTextStyle
	?? theme.textTheme.bodyText2?.copyWith(color: foregroundColor);

	TextStyle? titleTextStyle = backwardsCompatibility
	? widget.textTheme?.headline6
	?? appBarTheme.textTheme?.headline6
	?? theme.primaryTextTheme.headline6
	: widget.titleTextStyle
	?? appBarTheme.titleTextStyle
	?? theme.textTheme.headline6?.copyWith(color: foregroundColor);

[Documentation] AppBarTheme toolbarTextStyle and titleTextStyle documentation not following the current behavior #86127

Description

Activity

HansMuller commented on Jul 12, 2021

github-actions commented on Jul 30, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions