Skip to content

painting and widgets libraries should export FontFeature #87235

Closed
Closed
painting and widgets libraries should export FontFeature#87235
Assignees
Hixie
Labels
P3Issues that are less important to the Flutter projecta: qualityA truly polished experienceframeworkflutter/packages/flutter repository. See also f: labels.team-frameworkOwned by Framework teamtriaged-frameworkTriaged by Framework team

Description

@Hixie
Hixie
opened on Jul 28, 2021

Since FontFeature is part of the TextStyle API in painting, and TextStyle is part of the Text API in widgets, both should export FontFeature.

Ideally we'd have a lint that catches this kind of thing. A library should export all the types in the APIs it exposes.

cc @a14n

Activity

  1. Hixie
    added
    frameworkflutter/packages/flutter repository. See also f: labels.
    a: qualityA truly polished experience
    P3Issues that are less important to the Flutter project
    on Jul 28, 2021

  2. Hixie commented on Jul 28, 2021

    @Hixie
    Hixie
    on Jul 28, 2021
    ContributorAuthor

    Similar problem with ImageFilter.

  3. Hixie commented on Aug 5, 2021

    @Hixie
    Hixie
    on Aug 5, 2021
    ContributorAuthor

    Similarly material should expose SystemUiOverlayStyle since it's used in AppBar.

  4. Hixie commented on Aug 6, 2021

    @Hixie
    Hixie
    on Aug 6, 2021
    ContributorAuthor

    DragStartBehavior is used by a bunch of things in widgets but not re-exported.

  5. Hixie commented on Sep 7, 2021

    @Hixie
    Hixie
    on Sep 7, 2021
    ContributorAuthor

    LogicalKeyboardKey and a number of related types are exposed by Focus but not re-exported.

  6. mamuseferha
    added
    passed first triage
    on Nov 5, 2021
  7. flutter-triage-bot
    added
    team-frameworkOwned by Framework team
    triaged-frameworkTriaged by Framework team
    on Jul 8, 2023
  8. Hixie
    removed
    passed first triage
    on Jul 8, 2023
  9. Hixie
    self-assigned this
    on Nov 24, 2023
  10. auto-submit
    added a commit that references this issue on Nov 28, 2023

    [rfw, flutter_markdown] Prepare for removing dart:ui imports. (#5471)

    e4aaba8

  11. Hixie commented on Nov 29, 2023

    @Hixie
    Hixie
    on Nov 29, 2023
    ContributorAuthor

    i'm going to close this one and fix it on a case-by-case basis when i run into it.

  12. Hixie
    closed this as completedon Nov 29, 2023

  13. github-actions commented on Dec 13, 2023

    @github-actions
    github-actionsbot
    on Dec 13, 2023 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  14. github-actions
    locked as resolved and limited conversation to collaborators on Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P3Issues that are less important to the Flutter projecta: qualityA truly polished experienceframeworkflutter/packages/flutter repository. See also f: labels.team-frameworkOwned by Framework teamtriaged-frameworkTriaged by Framework team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions