Skip to content

Mac module_test_ios is 2.76% flaky #89175

Activity

  1. added
    c: flakeTests that sometimes, but not always, incorrectly pass
    toolAffects the "flutter" command-line tool. See also t: labels.
    on Aug 30, 2021
  2. cyanglaz commented on Sep 1, 2021

    @cyanglaz

    Looks like the flakeness is due to lots of timeouts:
    [module_test_ios] [STDOUT] stdout: /opt/s/w/ir/x/t/flutter_module_test.er8AG5/hello_host_app/FlutterUITests/FlutterUITests.m:39: error: -[FlutterUITests testFullScreenWarm] : (([app.staticTexts[@"Button tapped 0 times."] waitForExistenceWithTimeout:60.0]) is true) failed
    [FlutterUITests testFlutterViewWarm] : (([app.staticTexts[@"Button tapped 0 times."] waitForExistenceWithTimeout:60.0]) is true) failed

    Maybe we should increase the timeout and see what's going on.

  3. self-assigned this
    on Sep 1, 2021
  4. zanderso commented on Sep 6, 2021

    @zanderso
    Member

    Looks like a duplicate of #88286

  5. jmagman commented on Sep 7, 2021

    @jmagman
    Member

    II don't think this is a duplicate, the test is actually failing, not timing out.

    Screen Shot 2021-09-07 at 10 11 20 AM

    It's failing because the Flutter view isn't loading and the static text really isn't there:

    Screen Shot 2021-09-07 at 10 11 20 AM

    See test results from run: https://storage.googleapis.com/flutter_logs/flutter/c5861cfb56725f492e4a58d3dfdfca868c64dade/module_test_ios/f5624720-7397-42a0-a384-5e85faaf0355/module_test_ios-objc-2021-08-25T10:23:39.878872.zip

  6. reopened this on Sep 7, 2021
  7. cyanglaz commented on Sep 13, 2021

    @cyanglaz
  8. zanderso commented on Sep 14, 2021

    @zanderso
    Member

    @cyanglaz Are you continuing to investigate this, or are you blocked? Should we check the logs for dropped messages?

  9. 31 remaining items

  10. jmagman commented on Feb 9, 2022

    @jmagman
    Member
  11. fluttergithubbot commented on Feb 14, 2022

    @fluttergithubbot
    ContributorAuthor

    Current flaky ratio for the past (up to) 100 commits is 1.00%. Flaky number: 1; total number: 100.
    One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20module_test_ios/456
    Commit: ec58835
    Flaky builds:
    https://ci.chromium.org/ui/p/flutter/builders/staging/Mac%20module_test_ios/456

    Recent test runs:
    https://flutter-dashboard.appspot.com/#/build?taskFilter=Mac%20module_test_ios

  12. zanderso commented on Feb 14, 2022

    @zanderso
    Member

    Build 456 (2/9) was before the fix flutter-team-archive/engine#31416 from @jason-simmons rolled into the framework #98303 (2/11).

  13. jmagman commented on Feb 15, 2022

    @jmagman
    Member

    @keyonghan I don't see the reported https://ci.chromium.org/ui/p/flutter/builders/staging/Mac%20module_test_ios/456 flake in the list. That one was on ec58835 on 2/9, but the last flake I see in https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac%20module_test_ios%22 under Flakiness status for recent commits is d78377f from 2/7. Am I reading it wrong?

  14. keyonghan commented on Feb 15, 2022

    @keyonghan
    Contributor

    @keyonghan I don't see the reported https://ci.chromium.org/ui/p/flutter/builders/staging/Mac%20module_test_ios/456 flake in the list. That one was on ec58835 on 2/9, but the last flake I see in https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac%20module_test_ios%22 under Flakiness status for recent commits is d78377f from 2/7. Am I reading it wrong?

    The first two charts are for prod runs. As this test has been marked as bringup: true, it is running in the staging pool. Please take a look at the middle two charts. (by default it shows recent 50 commits. you could see the flake run if you increase the number to say 60).

  15. jmagman commented on Feb 15, 2022

    @jmagman
    Member

    That makes sense, thanks for the explainer!

  16. jmagman commented on Feb 23, 2022

    @jmagman
    Member

    Not seeing any recent staging flakes in the table, the bot didn't comment with new stats. @keyonghan should I wait for the bot to put out a PR to mark unflaky, or just do it myself?

  17. keyonghan commented on Feb 23, 2022

    @keyonghan
    Contributor

    The flake bot was shifted to Wed. (flutter/cocoon#1603), and it should be deflaked tomorrow if you can wait:-)

  18. fluttergithubbot commented on Feb 23, 2022

    @fluttergithubbot
    ContributorAuthor

    Current flaky ratio for the past (up to) 100 commits is 0.00%. Flaky number: 0; total number: 100.

  19. keyonghan commented on Feb 23, 2022

    @keyonghan
    Contributor

    Marking the test as fixed.

    The bot didn't deflake the test automatically due to this issue being still open. #99009 to manually deflake.

  20. github-actions commented on Mar 9, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  21. locked as resolved and limited conversation to collaborators on Mar 9, 2022
  22. added
    P0Critical issues such as a build break or regression
    and removed on Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P0Critical issues such as a build break or regressionc: flakeTests that sometimes, but not always, incorrectly passtoolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions