You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Shadows around cards are intense in latest build of Gallery/Shrine #8929
Discussed with @abarth and @sethladd this morning. The plan is to work with Skia and design over the next week to make sure we can get these new shadows to look at least as nice as the old ones. If not, we'll turn back on the old shadows and continue working.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
sethladd commentedon Mar 21, 2017
Not sure if this was intentional?
cc @jason-simmons
sethladd commentedon Mar 21, 2017
Looks like it's also in buttons, so maybe a systemic issue.
New build:
Version in Play Store:
abarth commentedon Mar 21, 2017
Probably from the new shadow drawing codepath. /cc @jason-simmons
HansMuller commentedon Mar 21, 2017
Two of the problems here:
HansMuller commentedon Mar 22, 2017
I hacked the cards demo to look more like the sample image from the elevations and shadows section of the Material spec: https://material.io/guidelines/material-design/elevation-shadows.html#elevation-shadows-shadows. As you can see, we're close.
elevation = 2, material design spec
elevation = 2, flutter
elevation = 8, material design spec
elevation = 8, flutter
Improve the shadow drawing parameters
Improve the shadow drawing parameters (#3499)
chinmaygarde commentedon Mar 24, 2017
Was this fixed by flutter-team-archive/engine#3499?
sethladd commentedon Mar 27, 2017
Doesn't look like we've matched the shadows to the spec yet. Just made a build:
Reference point (welcome screen from Keep):
eseidelGoogle commentedon Mar 27, 2017
I believe @jason-simmons is working on this. Marking M2, this will block customers.
eseidelGoogle commentedon Mar 28, 2017
Adding Skia label for @chinmaygarde's tracking.
sethladd commentedon Mar 29, 2017
Once this lands, I'll be happy to go through the Gallery again to see if we can ship an update.
sethladd commentedon Mar 29, 2017
See also shadows around FAB: #9083
eseidelGoogle commentedon Mar 30, 2017
Discussed with @abarth and @sethladd this morning. The plan is to work with Skia and design over the next week to make sure we can get these new shadows to look at least as nice as the old ones. If not, we'll turn back on the old shadows and continue working.
eseidelGoogle commentedon Apr 11, 2017
We've disabled physical model layer until Skia provides us updated config information, this can be punted to M3.
abarth commentedon May 4, 2017
Physical model is back on with less intensity.
github-actions commentedon Sep 5, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.