Skip to content

Audit webview_flutter tests #91004

Closed
flutter/packages
#6031

Description

@stuartmorgan-g

In the recent federation of the plugin's mobile implementations, many tests were duplicated from what is now the app-facing package to the platform implementations. We should audit what's in the those tests and eliminate duplicates where possible.

For instance, RunnerTests and RunnerUITests should almost certainly not still exist in the app-facing package, because they should be for testing native-code-specific behaviors (it's possible there are exceptions, which is why it needs to be an audit, but my assumption is that they should all go); the same is likely true of native Java tests. Dart integration-tests likely are more likely to be useful to duplicate (app-facing to get true end-to-end testing, implementation to get local testing so we find issue before publishing), but should get a check.

/cc @mvanbeusekom

Activity

  1. added
    a: tests"flutter test", flutter_test, or one of our tests
    P1High-priority issues at the top of the work list
    on Sep 30, 2021
  2. flutter-triage-bot commented on Dec 3, 2023

    @flutter-triage-bot

    This issue is marked P1 but has had no recent status updates.

    The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.

    Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!

  3. github-actions commented on Feb 23, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  4. locked as resolved and limited conversation to collaborators on Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P1High-priority issues at the top of the work lista: tests"flutter test", flutter_test, or one of our testsp: webviewThe WebView pluginpackageflutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions