Skip to content

Update flutter_mac_toolchain fork of depot_tools mac_toolchain to pick up new -skip-ref-tag argument #92051

Closed

Description

@jmagman

To support native arm64 Mac desktop apps, we need to add macOS 11 (Big Sur) SDK to the existing Xcode 12a7209 cipd package. I want to upload this, test it, then remove the old 12a7209 cipd package. However, the current flutter_mac_toolchain automatically uses the Xcode version for the ref tag, which means they will have duplicate tags.

depot_tools mac_toolchain added a -skip-ref-tag feature that will allow both to be uploaded at the same time for testing.
https://bugs.chromium.org/p/chromium/issues/detail?id=1225115#c4
https://chromium-review.googlesource.com/c/infra/infra/+/3219264

go/flutter-mac-toolchain needs to be updated to pick up this feature (and continue to not filter out the watchOS runtime).

Activity

  1. added
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    team-infraOwned by Infrastructure team
    P1High-priority issues at the top of the work list
    on Oct 19, 2021
  2. jmagman commented on Oct 19, 2021

    @jmagman
    MemberAuthor
  3. changed the title [-]Update flutter_mac_toolchain fork of depot_tools mac_toolchain to pick up new `-skip-ref-tag` argument[/-] [+]Update flutter_mac_toolchain fork of depot_tools `mac_toolchain` to pick up new `-skip-ref-tag` argument[/+] on Oct 19, 2021
  4. changed the title [-]Update flutter_mac_toolchain fork of depot_tools `mac_toolchain` to pick up new `-skip-ref-tag` argument[/-] [+]Update `flutter_mac_toolchain` fork of depot_tools `mac_toolchain` to pick up new `-skip-ref-tag` argument[/+] on Oct 19, 2021
  5. godofredoc commented on Oct 19, 2021

    @godofredoc
    Contributor

    Updated the go link to point to the new binary. Please give it a try and let me know if it works correctly.

  6. jmagman commented on Oct 19, 2021

    @jmagman
    MemberAuthor

    @godofredoc I couldn't run it on my Mac.

    zsh: exec format error: ./flutter_mac_toolchain_10182021
    
  7. godofredoc commented on Oct 19, 2021

    @godofredoc
    Contributor

    ahhh, totally forgot that generated the binary in my linux desktop.

  8. godofredoc commented on Oct 20, 2021

    @godofredoc
    Contributor

    go/flutter-mac-toolchain was updated to a mac binary.

  9. jmagman commented on Oct 22, 2021

    @jmagman
    MemberAuthor

    It ran this time, and I see the new flag:

      -skip-ref-tag
        	Whether to skip attaching CIPD tags or refs for Xcode packages to be uploaded.
    

    Will close this after I test it.

  10. jmagman commented on Oct 22, 2021

    @jmagman
    MemberAuthor

    @godofredoc the executable is named flutter_mac_toolchain_10202021, can you rename to flutter_mac_toolchain so we don't need to change the documentation?
    Trying an upload now.

  11. godofredoc commented on Oct 22, 2021

    @godofredoc
    Contributor

    Sure let me remove the other versions of my drive and rename.

  12. godofredoc commented on Oct 22, 2021

    @godofredoc
    Contributor

    File was renamed!

  13. jmagman commented on Oct 26, 2021

    @jmagman
    MemberAuthor

    It worked, thank you!

  14. github-actions commented on Nov 9, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  15. locked as resolved and limited conversation to collaborators on Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.team-infraOwned by Infrastructure team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions