Skip to content

Pubspec for a plugin should be able to capture build dependencies #9214

Closed

Description

@mit-mit

From @collinjackson: If you try to build an app that consumes a plugin with gmscore dependencies, it fails until you add something like this to build.gradle of the app:

classpath 'com.google.gms:google-services:3.0.0'
apply plugin: 'com.google.gms.google-services'

It would be better if you could specify these dependencies in the pubspec.yaml file of the plugin and than have the build step inject this into the app.

Activity

  1. mit-mit commented on Apr 5, 2017

    @mit-mit
    MemberAuthor

    Tentatively tagging M2 as this impacts our hero scenario for that

  2. modified the milestones: , 2: Make Early Adopters happy on Apr 11, 2017
  3. eseidelGoogle commented on Apr 11, 2017

    @eseidelGoogle
    Contributor

    Tentatively punting. Please feel free to pull back if you feel it's important.

  4. mit-mit commented on Sep 13, 2017

    @mit-mit
    MemberAuthor

    Need to investigate

  5. self-assigned this
    on Sep 13, 2017
  6. Hixie commented on Dec 18, 2017

    @Hixie
    Contributor

    Leaving in current milestone since this seems like plugin framework maintenance work, which is considered a top priority according to our priority list.

  7. removed their assignment
    on Jan 29, 2018
  8. self-assigned this
    on Feb 7, 2018
  9. cbracken commented on Feb 23, 2018

    @cbracken
    Member

    @mravn-google triaging - any updates?

  10. removed their assignment
    on Feb 28, 2018
  11. mit-mit commented on Apr 6, 2018

    @mit-mit
    MemberAuthor

    Postponing to milestone 4.

  12. modified the milestones: 3: Current Milestone, on Apr 6, 2018
  13. amirh commented on Mar 29, 2019

    @amirh
    Contributor

    @mit-mit any updates? should this be tracked as a pub issue as well?

  14. added
    P2Important issues not at the top of the work list
    on May 29, 2020
  15. removed this from the milestone on Jun 2, 2020
  16. removed this from the milestone on Jun 2, 2020
  17. removed this from the milestone on Aug 17, 2020
  18. stuartmorgan-g commented on Feb 21, 2023

    @stuartmorgan-g
    Contributor

    Is this describing an obsolete issue? Generally plugin native dependencies are handled automatically by the build, and don't need app-level intervention.

  19. mit-mit commented on Feb 22, 2023

    @mit-mit
    MemberAuthor

    Yeah, I think this is stale

  20. github-actions commented on Mar 8, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  21. locked as resolved and limited conversation to collaborators on Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listp: toolingAffects the flutter_plugin_tools packagepackageflutter/packages repository. See also p: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions