Skip to content

[web] CanvasKit goldens seem to be using incorrect transform #93263

Description

@yjbanov

CanvasKit goldens submitted to Skia Gold are smaller than those submitted from other platforms. While most are still legible enough to triage, some are way too small, e.g.:

another-small-golden

We should fix this for better maintainability.

Some screenshots end up shifting and clipping the content in addition to scaling it down. For example, painting.radial_gradient_90 is submitted as:

canvaskit-golden-clipped

but it should have looked like this:

expected-radial-gradient

Activity

  1. added
    a: tests"flutter test", flutter_test, or one of our tests
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    frameworkflutter/packages/flutter repository. See also f: labels.
    engineflutter/engine related. See also e: labels.
    e: web_canvaskitCanvasKit (a.k.a. Skia-on-WebGL) rendering backend for Web
    P1High-priority issues at the top of the work list
    on Nov 8, 2021
  2. Piinks commented on Nov 17, 2022

    @Piinks
    Contributor

    This needs to be fixed before we can land #115004

  3. flutter-triage-bot commented on Dec 26, 2023

    @flutter-triage-bot

    This issue is marked P1 but has had no recent status updates.

    The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.

    Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!

  4. added
    P2Important issues not at the top of the work list
    triaged-webTriaged by Web platform team
    and removed
    P1High-priority issues at the top of the work list
    on Feb 22, 2024
  5. harryterkelsen commented on Aug 7, 2024

    @harryterkelsen
    Contributor

    This is fixed

  6. github-actions commented on Aug 21, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. locked as resolved and limited conversation to collaborators on Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.e: web_canvaskitCanvasKit (a.k.a. Skia-on-WebGL) rendering backend for Webengineflutter/engine related. See also e: labels.frameworkflutter/packages/flutter repository. See also f: labels.platform-webWeb applications specificallyteam-webOwned by Web platform teamtriaged-webTriaged by Web platform team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions