Repository navigation
[web] CanvasKit goldens seem to be using incorrect transform #93263
Description
Activity
- addeda: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.e: web_canvaskitCanvasKit (a.k.a. Skia-on-WebGL) rendering backend for WebCanvasKit (a.k.a. Skia-on-WebGL) rendering backend for WebP1High-priority issues at the top of the work listHigh-priority issues at the top of the work list
on Nov 8, 2021 This needs to be fixed before we can land #115004
- addedteam-webOwned by Web platform teamOwned by Web platform teamtriaged-webTriaged by Web platform teamTriaged by Web platform team
on Jul 8, 2023 - removedtriaged-webTriaged by Web platform teamTriaged by Web platform team
on Dec 26, 2023 This issue is marked P1 but has had no recent status updates.
The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.
Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!
- addedP2Important issues not at the top of the work listImportant issues not at the top of the work listtriaged-webTriaged by Web platform teamTriaged by Web platform teamand removedP1High-priority issues at the top of the work listHigh-priority issues at the top of the work list
on Feb 22, 2024 This is fixed
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Aug 21, 2024
CanvasKit goldens submitted to Skia Gold are smaller than those submitted from other platforms. While most are still legible enough to triage, some are way too small, e.g.:
We should fix this for better maintainability.
Some screenshots end up shifting and clipping the content in addition to scaling it down. For example, painting.radial_gradient_90 is submitted as:
but it should have looked like this: