Skip to content

Unify Android artifact / version checks #9429

Closed
Closed
Unify Android artifact / version checks#9429
Labels
P3Issues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.c: tech-debtTechnical debt, code quality, testing, etc.platform-androidAndroid applications specificallyt: flutter doctorProblem related to the "flutter doctor" tooltoolAffects the "flutter" command-line tool. See also t: labels.

Description

@johnmccutchan
johnmccutchan
opened on Apr 17, 2017

Currently there are duplicated checks (e.g. java location and version) in lib/src/android/android_workflow.dart and lib/src/android/android_studio.dart.

There should be one canonical Java locator / version checker that is shared between all components that need it (Android build steps, Flutter doctor checks, etc).

Activity

  1. johnmccutchan
    added
    toolAffects the "flutter" command-line tool. See also t: labels.
    on Apr 17, 2017

  2. johnmccutchan commented on Apr 17, 2017

    @johnmccutchan
    johnmccutchan
    on Apr 17, 2017
    ContributorAuthor

    Related #9134

  3. johnmccutchan commented on Apr 17, 2017

    @johnmccutchan
    johnmccutchan
    on Apr 17, 2017
    ContributorAuthor

    @jakobr-google @mit-mit

  4. Hixie
    added
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    on Jan 3, 2018
  5. Hixie
    added this to the milestone on Jan 3, 2018

  6. zoechi commented on Nov 30, 2018

    @zoechi
    zoechi
    on Nov 30, 2018
    Contributor

    Related #10351

  7. zanderso
    added
    t: flutter doctorProblem related to the "flutter doctor" tool
    platform-androidAndroid applications specifically
    on Jan 15, 2020
  8. kf6gpe
    added
    P6
    on May 29, 2020
  9. Hixie
    removed this from the milestone on Dec 10, 2020

  10. pedromassangocode commented on Feb 19, 2021

    @pedromassangocode
    pedromassangocode
    on Feb 19, 2021

    Assuming that the files in question are:
    https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/android/android_studio.dart
    https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/android/android_workflow.dart

    This issue is still valid.

  11. pedromassangocode
    added
    passed first triage
    c: tech-debtTechnical debt, code quality, testing, etc.
    on Feb 19, 2021

  12. andrewkolos commented on Apr 5, 2023

    @andrewkolos
    andrewkolos
    on Apr 5, 2023
    Contributor

    Closing as superseded by #124252 as I didn't realize this issue existed until I already added a mention of #124252 in some code docs.

  13. andrewkolos
    closed this as completedon Apr 5, 2023

  14. github-actions commented on Apr 19, 2023

    @github-actions
    github-actionsbot
    on Apr 19, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  15. github-actions
    locked as resolved and limited conversation to collaborators on Apr 19, 2023
  16. flutter-triage-bot
    added
    P3Issues that are less important to the Flutter project
    and removed
    P6
    on Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.c: tech-debtTechnical debt, code quality, testing, etc.platform-androidAndroid applications specificallyt: flutter doctorProblem related to the "flutter doctor" tooltoolAffects the "flutter" command-line tool. See also t: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions