Skip to content

Crossdart fails for plugins #9547

Closed
Closed

Description

@mit-mit

Crossdart has no info for url_launcher:
https://pub.dartlang.org/packages/url_launcher + click 'source code'

Log file:
https://www.crossdart.info/p/url_launcher/0.1.1/log.txt

Activity

  1. modified the milestones: , 2: Make Early Adopters happy on Apr 25, 2017
  2. eseidelGoogle commented on Apr 25, 2017

    @eseidelGoogle
    Contributor

    I don't think this blocks M2. But I'm glad we noticed. :)

  3. mit-mit commented on Apr 27, 2017

    @mit-mit
    MemberAuthor

    I think the fix for this is to:

    1. get a Flutter SDK installed on the crossdart builder
      • This is git clone https://github.com/flutter/flutter.git
    2. set the environment variable FLUTTER_ROOT to the path of the Flutter SDK so that Pub/Dartdoc/etc. can locate the Flutter SDK.
  4. mit-mit commented on Apr 27, 2017

    @mit-mit
    MemberAuthor

    A bit of experimentation to back this theory:

    mit-macbookpro2:url-launcher mit$ dartdoc
    Resolving dependencies...
    Resolving dependencies...
    
    The Flutter SDK is not available.
    Depended on by:
    - url_launcher
    mit-macbookpro2:url-launcher mit$ export FLUTTER_ROOT=~/dev/github/flutter
    mit-macbookpro2:url-launcher mit$ dartdoc
    Resolving dependencies...
    Got dependencies!
    Generating documentation for 'url_launcher' into /Users/mit/tmp/plugins/packages/url-launcher/doc/api/
    
  5. szakarias commented on Apr 27, 2017

    @szakarias
    Contributor
  6. astashov commented on Apr 27, 2017

    @astashov

    I tried that, now it complains:

    $ pub get
    Resolving dependencies... 
    Could not find package sky_engine at "/flutter/bin/cache/pkg/sky_engine".
    Depended on by:
    - flutter 0.0.22 

    I checked - there's no that sky_engine indeed. Where to get it?

  7. mit-mit commented on Apr 27, 2017

    @mit-mit
    MemberAuthor

    Oh, sorry, I think we are missing a step: After the git clone, can you try to run flutter\bin\flutter precache?

  8. astashov commented on Apr 27, 2017

    @astashov

    Umm, it complains:

       Woah! You appear to be trying to run flutter as root.
       We strongly recommend running the flutter tool without superuser privileges.
      /
    📎
    

    I know, I know, but I really want to run it with root... Is there a way to workaround this?

  9. mit-mit commented on Apr 27, 2017

    @mit-mit
    MemberAuthor

    Don't think that we currently support that; let me dig a bit and see if that can get changed!

  10. Hixie commented on Apr 27, 2017

    @Hixie
    Contributor

    @astashov Why do you want to run as root?

  11. astashov commented on Apr 27, 2017

    @astashov

    I just run everything in a GCE startup script, which is root by default. Maybe not a best decision, but would require some effort to change that. Curious why it's so bad to run it under root?

  12. mit-mit commented on May 2, 2017

    @mit-mit
    MemberAuthor

    @astashov do you think you will be able to change your script to not run as root?

  13. 5 remaining items

  14. mit-mit commented on May 16, 2017

    @mit-mit
    MemberAuthor

    Would really like to see a resolution to this. Having 404s from plugin landing pages is not a good user experience. @astashov do you think you will get to this soon?

  15. astashov commented on May 16, 2017

    @astashov

    Don't have much time now, unfortunately. Actually, gonna try to look into it this night, will see what I could do there.

  16. eseidelGoogle commented on May 16, 2017

    @eseidelGoogle
    Contributor

    We can remove the root restriction if absolutely necessary (or at a temporary flag to override the check). Running as root inside a VM isn't really that harmful. But letting normal users accidentally run as root is just handing them a footgun.

  17. added a commit that references this issue on May 17, 2017
  18. mit-mit commented on May 17, 2017

    @mit-mit
    MemberAuthor

    @astashov we removed the root restriction, can you try the fix from three weeks ago again?

  19. astashov commented on May 17, 2017

    @astashov

    Oh really? And I'm trying to run it not under root like right now... :)

  20. mit-mit commented on May 17, 2017

    @mit-mit
    MemberAuthor

    Yes, sorry about flip-flopping. Just merged it in 97f7ddf.

  21. Hixie commented on May 17, 2017

    @Hixie
    Contributor

    @astashov Long term we want to put the restriction back, FWIW. But we wanted to unblock you.

  22. mit-mit commented on May 17, 2017

    @mit-mit
    MemberAuthor

    @astashov is it working now with the root restriction removed? Or are you hitting new problems?

  23. astashov commented on May 17, 2017

    @astashov

    Hitting new problems - by some reason the script either ignores or doesn't see FLUTTER_ROOT. I'll continue investigating tonight.

  24. astashov commented on May 18, 2017

    @astashov

    Okay, I think it is fixed. I also think it'd work now even with the root restriction.

  25. mit-mit commented on May 18, 2017

    @mit-mit
    MemberAuthor

    Excellent news, great to see this fixed. Thanks a lot!

  26. github-actions commented on Aug 17, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  27. locked as resolved and limited conversation to collaborators on Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

p: toolingAffects the flutter_plugin_tools package

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions