FlutterAppDelegate should forward delegate methods to plugins that register for them #9682

Activity

1. mravn-google

   self-assigned this

   on Apr 28, 2017
2. mravn-google commented on Apr 28, 2017

   

   mravn-google

   on Apr 28, 2017

   Contributor

   More actions

   I am. Thanks for creating the issue.
3. mravn-google commented on May 1, 2017

   

   mravn-google

   on May 1, 2017

   Last edited by mravn-google

   Contributor

   More actions

   Below are the (non-deprecated) UIApplicationDelegate methods. Many of them may introduce cross-plugin interference, if we (or plugin implementors) are not careful.

   Examples: some of them take a completion handler argument, and can logically only be delegated to one plugin. Others might be sensitive to plugin ordering, like those that take NSCoder arguments for storing/restoring state.

   Another issue is that implementing some of these methods require a corresponding configuration entry in Info.plist, lest Xcode will say e.g.

   You've implemented -[<UIApplicationDelegate> application:didReceiveRemoteNotification:fetchCompletionHandler:],
   but you still need to add "remote-notification" to the list of your supported
   UIBackgroundModes in your Info.plist.
   

   Do we want to add such an entry to our templates?

   application:willFinishLaunchingWithOptions:
   application:didFinishLaunchingWithOptions:
   applicationDidBecomeActive:
   applicationWillResignActive:
   applicationDidEnterBackground:
   applicationWillEnterForeground:
   applicationWillTerminate:
   applicationProtectedDataWillBecomeUnavailable:
   applicationProtectedDataDidBecomeAvailable:
   applicationDidReceiveMemoryWarning:
   applicationSignificantTimeChange:
   application:shouldSaveApplicationState:
   application:shouldRestoreApplicationState:
   application:viewControllerWithRestorationIdentifierPath:coder:
   application:willEncodeRestorableStateWithCoder:
   application:didDecodeRestorableStateWithCoder:
   application:performFetchWithCompletionHandler:
   application:handleEventsForBackgroundURLSession:completionHandler:
   application:didRegisterUserNotificationSettings:
   application:didRegisterForRemoteNotificationsWithDeviceToken:
   application:didFailToRegisterForRemoteNotificationsWithError:
   application:didReceiveRemoteNotification:fetchCompletionHandler:
   application:willContinueUserActivityWithType:
   application:continueUserActivity:restorationHandler:
   application:didUpdateUserActivity:
   application:didFailToContinueUserActivityWithType:error:
   application:performActionForShortcutItem:completionHandler:
   application:handleWatchKitExtensionRequest:reply:
   applicationShouldRequestHealthAuthorization:
   application:openURL:options:
   application:shouldAllowExtensionPointIdentifier:
   application:supportedInterfaceOrientationsForWindow:
   application:willChangeStatusBarOrientation:duration:
   application:didChangeStatusBarOrientation:
   application:willChangeStatusBarFrame:
   application:didChangeStatusBarFrame:
   application:userDidAcceptCloudKitShareWithMetadata:
   
4. mit-mit

   added

   c: API breakBackwards-incompatible API changesBackwards-incompatible API changes

   plugin: framework

   on May 2, 2017
5. collinjackson

   added this to the 3: Make conferences happyThis milestone has been deleted milestone on May 2, 2017
6. mravn-google commented on May 9, 2017

   

   mravn-google

   on May 9, 2017

   Contributor

   More actions

   Fixed by #9818 and friends.
7. mravn-google

   closed this as completedon May 9, 2017
8. github-actions commented on Sep 5, 2021

   

   github-actionsbot

   on Sep 5, 2021

   More actions

   This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
9. github-actions

   locked as resolved and limited conversation to collaborators on Sep 5, 2021