Skip to content

Framework's matchesGoldenFile should assert that file name has right structure #98943

Description

@goderbauer

#98772 broke the tree because the file name provided to matchesGoldenFile was missing .png. We should assert that file names have the right structure - maybe even that they are unique at least for the given file?

incorrect:

matchesGoldenFile('slider_start_text_scale_1_width_0'),

correct:

matchesGoldenFile('slider_start_text_scale_1_width_0.png'),

Activity

  1. added
    a: tests"flutter test", flutter_test, or one of our tests
    frameworkflutter/packages/flutter repository. See also f: labels.
    P2Important issues not at the top of the work list
    on Feb 22, 2022
  2. goderbauer commented on Feb 22, 2022

    @goderbauer
    MemberAuthor
  3. self-assigned this
    on Feb 22, 2022
  4. harryterkelsen commented on Feb 24, 2022

    @harryterkelsen
    Contributor

    The fix was reverted here: #99075

  5. github-actions commented on Mar 11, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.c: flakeTests that sometimes, but not always, incorrectly passframeworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions