Repository navigation
Analyzer failing on Excellent news! A package dependency has been removed! cli_util #99036
Description
Tree is closed on unrelated PR #98604
https://ci.chromium.org/p/flutter/builders/prod/Linux%20analyze/6101?
All analyzer checks are passing, but the output ends with:
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Excellent news! A package dependency has been removed!
cli_util
To make sure we do not accidentally add this dependency back in the future,
please remove this packages from the allow-list in dev/bots/allowlist.dart.
Thanks!
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Guessing that "excellent news" is an unexpected output and is being interpreted as failing?
Activity
jmagman commentedon Feb 24, 2022
I ran
flutter update-packages --force-upgradebut all thepubspec.locks still containcli_util...jmagman commentedon Feb 24, 2022
This is coming from
flutter/dev/bots/analyze.dart
Lines 1569 to 1571 in 87fe3fe
flutter/packages/flutter_tools/lib/src/commands/update_packages.dart
Lines 78 to 80 in 54a9d65
So it's not about our package lock files, it's about the consumer-facing packages.
I see traffic from @devoncarew removing this dep like https://dart-review.googlesource.com/c/sdk/+/232423 so this looks expected.
christopherfujino commentedon Feb 24, 2022
Thanks for fixing this @jmagman. The reason this test failed out of band, rather than on an update packages roll is #91757.
devoncarew commentedon Feb 24, 2022
@jmagman - thanks for the fix in #99037! I didn't realize that reducing deps would break CIs.
jmagman commentedon Feb 24, 2022
Neither did I, at least it was cheery "Excellent news!" 😄
github-actions commentedon Mar 10, 2022
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.