Skip to content

Apply soft-transition to devtools for ClipboardStatusNotifier change #99360

Description

@chunhtai

The c74a646 breaks devtools

devtools_app/lib/src/debugger/variables.dart

170: Widget buildToolbar(                                                  'VariableSelectionControls.buildToolbar' ('Widget*
                                                                           Function(BuildContext*, Rect*, double*, Offset*,
                                                                           List<TextSelectionPoint*>*, TextSelectionDelegate*,
                                                                           ClipboardStatusNotifier*, Offset*)*') isn't a valid override of
                                                                           'MaterialTextSelectionControls.buildToolbar' ('Widget
                                                                           Function(BuildContext, Rect, double, Offset,
                                                                           List<TextSelectionPoint>, TextSelectionDelegate,
                                                                           ValueListenable<ClipboardStatus>?, Offset?)'). #invalid_override

188: canCut(delegate) ? () => handleCut(delegate, clipboardStatus) : null, Too many positional arguments: 1 expected, but 2 found.
                                                                           #extra_positional_arguments

190: ? () => handleCopy(delegate, clipboardStatus)                         Too many positional arguments: 1 expected, but 2 found.
                                                                           #extra_positional_arguments

272: if (!widget.clipboardStatus.disposed) {                               The getter 'disposed' isn't defined for the type
                                                                           'ClipboardStatusNotifier'. #undefined_getter

We need to do a soft transition instead

Activity

  1. added
    a: devtoolsDevTools related - suite of performance and debugging tools
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Mar 1, 2022
  2. self-assigned this
    on Mar 1, 2022
  3. added
    P1High-priority issues at the top of the work list
    on Mar 2, 2022
  4. chunhtai commented on Mar 2, 2022

    @chunhtai
    ContributorAuthor

    Reland merged, next step:

    1. wait for a beta release
    2. pin devtool to that beta version and apply migrations
    3. clean up the todos in the ClipboardStatusNofifier and TextSelectionControls
  5. chunhtai commented on Aug 11, 2022

    @chunhtai
    ContributorAuthor

    change reverted

  6. rekire commented on Aug 15, 2022

    @rekire
    Contributor

    Quick question about this ticket: This is just about the status if the access to the clipboard is possible right?
    I was looking for a solution to observe clipboard changes.

  7. chunhtai commented on Aug 15, 2022

    @chunhtai
    ContributorAuthor

    @rekire You can create a ClipboardStatusNotifier and call update to get the latest status, It can only do polling.

  8. JeisonSanches commented on Jan 25, 2023

    @JeisonSanches

    @chunhtai This was already fixed, right?

  9. github-actions commented on May 5, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  10. locked as resolved and limited conversation to collaborators on May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work lista: devtoolsDevTools related - suite of performance and debugging toolsframeworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions