Skip to content

Mac_ios platform_views_scroll_perf_ios crashes. #99488

Closed
Closed
Mac_ios platform_views_scroll_perf_ios crashes.#99488
Labels
P1High-priority issues at the top of the work listc: fatal crashCrashes that terminate the processdependency: fuchsiaFuchsia team may need to help usengineflutter/engine related. See also e: labels.

Description

@zanderso
zanderso
opened on Mar 3, 2022

The framework tree is currently red on an Engine roll here #99459.

https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20platform_views_scroll_perf_ios__timeline_summary/3818/overview

It looks like the main thread is crashing in a call to GrMtlIsAppInBackground().

The Engine roll contains a clang roll. I will revert the Engine roll, stop the Engine rollers, and then speculatively revert the clang rolls if the framework tree returns to green.

Activity

  1. zanderso
    added
    engineflutter/engine related. See also e: labels.
    P0Critical issues such as a build break or regression
    c: fatal crashCrashes that terminate the process
    on Mar 3, 2022

  2. zanderso commented on Mar 3, 2022

    @zanderso
    zanderso
    on Mar 3, 2022
    MemberAuthor

    @chinmaygarde @jason-simmons @gaaclarke for more eyes on the backtrace.

  3. zanderso commented on Mar 3, 2022

    @zanderso
    zanderso
    on Mar 3, 2022
    MemberAuthor

    @gaaclarke Can you ptal and check whether there's any chance this is caused by flutter-team-archive/engine#31720? The current theory is the clang rolls, but 31720 would be the next possibly to look into if it's not the clang rolls.

  4. gaaclarke commented on Mar 3, 2022

    @gaaclarke
    gaaclarke
    on Mar 3, 2022
    Member

    Yea here is the stacktrace:

    Process 1404 stopped
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ] * thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGSEGV
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #0: 0x000000010595eb6c Flutter`GrMtlIsAppInBackground() + 72
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ] Flutter`GrMtlIsAppInBackground:
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ] ->  0x10595eb6c <+72>: ldr    x1, [x8, #0x420]
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     0x10595eb70 <+76>: bl     0x105da0018               ; symbol stub for: objc_msgSend
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     0x10595eb74 <+80>: cmp    x0, #0x2                  ; =0x2 
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     0x10595eb78 <+84>: cset   w20, eq
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ] Target 0: (Runner) stopped.
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ] thread backtrace all
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ] process detach
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [  +77 ms] * thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGSEGV
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]   * frame #0: 0x000000010595eb6c Flutter`GrMtlIsAppInBackground() + 72
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #1: 0x000000010594dfb8 Flutter`GrMtlCommandBuffer::getRenderCommandEncoder(MTLRenderPassDescriptor*, GrMtlOpsRenderPass*) + 44
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #2: 0x0000000105953498 Flutter`GrMtlGpu::onGetOpsRenderPass(GrRenderTarget*, bool, GrAttachment*, GrSurfaceOrigin, SkIRect const&, GrOpsRenderPass::LoadAndStoreInfo const&, GrOpsRenderPass::StencilLoadAndStoreInfo const&, SkTArray<GrSurfaceProxy*, true> const&, GrXferBarrierFlags) + 736
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #3: 0x00000001058eafc0 Flutter`skgpu::v1::OpsTask::onExecute(GrOpFlushState*) + 1252
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #4: 0x000000010585093c Flutter`GrDrawingManager::flush(SkSpan<GrSurfaceProxy*>, SkSurface::BackendSurfaceAccess, GrFlushInfo const&, GrBackendSurfaceMutableState const*) + 4452
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #5: 0x0000000105851598 Flutter`GrDrawingManager::flushSurfaces(SkSpan<GrSurfaceProxy*>, SkSurface::BackendSurfaceAccess, GrFlushInfo const&, GrBackendSurfaceMutableState const*) + 164
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #6: 0x000000010571715c Flutter`SkCanvas::onFlush() + 72
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #7: 0x00000001056f6708 Flutter`flutter::IOSExternalViewEmbedder::SubmitFrame(GrDirectContext*, std::__1::unique_ptr<flutter::SurfaceFrame, std::__1::default_delete<flutter::SurfaceFrame> >) + 1256
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #8: 0x0000000105a90190 Flutter`flutter::Rasterizer::DrawToSurfaceUnsafe(flutter::FrameTimingsRecorder&, flutter::LayerTree&) + 964
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #9: 0x0000000105a90a98 Flutter`std::__1::__function::__func<flutter::Rasterizer::DrawToSurface(flutter::FrameTimingsRecorder&, flutter::LayerTree&)::$_8, std::__1::allocator<flutter::Rasterizer::DrawToSurface(flutter::FrameTimingsRecorder&, flutter::LayerTree&)::$_8>, void ()>::operator()() + 28
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #10: 0x00000001059b74ac Flutter`fml::SyncSwitch::Execute(fml::SyncSwitch::Handlers const&) const + 52
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #11: 0x0000000105a8fc9c Flutter`flutter::Rasterizer::DrawToSurface(flutter::FrameTimingsRecorder&, flutter::LayerTree&) + 272
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #12: 0x0000000105a91b3c Flutter`std::__1::__function::__func<flutter::Rasterizer::Draw(std::__1::unique_ptr<flutter::FrameTimingsRecorder, std::__1::default_delete<flutter::FrameTimingsRecorder> >, std::__1::shared_ptr<flutter::Pipeline<flutter::LayerTree> >, std::__1::function<bool (flutter::LayerTree&)>)::$_2, std::__1::allocator<flutter::Rasterizer::Draw(std::__1::unique_ptr<flutter::FrameTimingsRecorder, std::__1::default_delete<flutter::FrameTimingsRecorder> >, std::__1::shared_ptr<flutter::Pipeline<flutter::LayerTree> >, std::__1::function<bool (flutter::LayerTree&)>)::$_2>, void (std::__1::unique_ptr<flutter::LayerTree, std::__1::default_delete<flutter::LayerTree> >)>::operator()(std::__1::unique_ptr<flutter::LayerTree, std::__1::default_delete<flutter::LayerTree> >&&) + 160
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #13: 0x0000000105a90d9c Flutter`flutter::Rasterizer::Draw(std::__1::unique_ptr<flutter::FrameTimingsRecorder, std::__1::default_delete<flutter::FrameTimingsRecorder> >, std::__1::shared_ptr<flutter::Pipeline<flutter::LayerTree> >, std::__1::function<bool (flutter::LayerTree&)>) + 644
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #14: 0x0000000105a917a8 Flutter`std::__1::__function::__func<fml::internal::CopyableLambda<flutter::Rasterizer::Draw(std::__1::unique_ptr<flutter::FrameTimingsRecorder, std::__1::default_delete<flutter::FrameTimingsRecorder> >, std::__1::shared_ptr<flutter::Pipeline<flutter::LayerTree> >, std::__1::function<bool (flutter::LayerTree&)>)::$_0>, std::__1::allocator<fml::internal::CopyableLambda<flutter::Rasterizer::Draw(std::__1::unique_ptr<flutter::FrameTimingsRecorder, std::__1::default_delete<flutter::FrameTimingsRecorder> >, std::__1::shared_ptr<flutter::Pipeline<flutter::LayerTree> >, std::__1::function<bool (flutter::LayerTree&)>)::$_0> >, void ()>::operator()() + 220
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #15: 0x00000001059b5d70 Flutter`fml::MessageLoopImpl::FlushTasks(fml::FlushType) + 1612
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #16: 0x00000001059b98d8 Flutter`fml::MessageLoopDarwin::OnTimerFire(__CFRunLoopTimer*, fml::MessageLoopDarwin*) + 32
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #17: 0x0000000185b99fcc CoreFoundation`<redacted> + 28
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #18: 0x0000000185b24338 CoreFoundation`<redacted> + 1016
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #19: 0x0000000185b1efcc CoreFoundation`<redacted> + 324
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #20: 0x0000000185afeea4 CoreFoundation`<redacted> + 1948
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #21: 0x0000000185b11d7c CoreFoundation`CFRunLoopRunSpecific + 572
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #22: 0x000000019fd869a0 GraphicsServices`GSEventRunModal + 160
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #23: 0x000000018834405c UIKitCore`<redacted> + 1080
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #24: 0x00000001880d9ce0 UIKitCore`UIApplicationMain + 2028
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #25: 0x00000001041bf4fc Runner`main(argc=<unavailable>, argv=<unavailable>) at main.m:11:16 [opt]
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #26: 0x0000000104380190 dyld`start + 444

    flutter-team-archive/engine#31720 does not sound related. It should have no effect on existing logic. It refactored the code to move logic from one place to another so that there is another entrypoint to execute it from dart. If it did cause problems I would have expected them to be around creating the dart isolate or an error in the dart plugin registrant.

  5. zanderso commented on Mar 3, 2022

    @zanderso
    zanderso
    on Mar 3, 2022
    MemberAuthor

    Mac_ios platform_views_scroll_perf_ios passed after the clang revert: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20platform_views_scroll_perf_ios__timeline_summary/3822/overview

  6. zanderso
    added
    dependency: fuchsiaFuchsia team may need to help us
    P1High-priority issues at the top of the work list
    and removed
    P0Critical issues such as a build break or regression
    on Mar 3, 2022

  7. zanderso commented on Mar 3, 2022

    @zanderso
    zanderso
    on Mar 3, 2022
    MemberAuthor

    Dropping to P3 since the Engine -> Framework roll is now unblocked.

  8. zanderso commented on Mar 4, 2022

    @zanderso
    zanderso
    on Mar 4, 2022
    MemberAuthor

    /cc @petrhosek Our clang roll is blocked on this. I'm not sure what info you would need to help debug.

  9. petrhosek commented on Mar 4, 2022

    @petrhosek
    petrhosek
    on Mar 4, 2022
    Contributor

    Do you have any additional information aside from the stacktrace? Is it possible to reproduce this locally and if so are there instructions? If the issue is non-obvious, we could try to bisect this.

  10. zanderso commented on Mar 5, 2022

    @zanderso
    zanderso
    on Mar 5, 2022
    MemberAuthor

    Aside from the stack trace, the Engine for this test was configured with:

    flutter/tools/gn --goma --ios --runtime-mode profile --bitcode

    which will target arm64 and use --lto.

    This is probably difficult to reproduce, but one would star by checking out flutter/flutter at:

    a786f65

    And running the benchmark. The bot is running the benchmark on a macOS host with an iPhone attached by running this script:

    https://github.com/flutter/flutter/blob/master/dev/devicelab/bin/test_runner.dart

    with the arguments listed here:

    https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8820699371982729905/+/u/run_platform_views_scroll_perf_ios__timeline_summary/execution_details

    (runner.sh is just a wrapper around test_runner.dart).

  11. petrhosek commented on Mar 7, 2022

    @petrhosek
    petrhosek
    on Mar 7, 2022
    Contributor

    We're not currently set up to reproduce an issue like this locally. Can we get some help from the Flutter team? Can you try and reduce this down to a smaller reproducer? Can we use Flutter's infrastructure to build and run your tests with different toolchain versions?

  12. 20 remaining items

  13. gaaclarke commented on Mar 11, 2022

    @gaaclarke
    gaaclarke
    on Mar 11, 2022 · Hidden as outdated

  14. gaaclarke commented on Mar 15, 2022

    @gaaclarke
    gaaclarke
    on Mar 15, 2022 · Hidden as outdated

  15. gaaclarke commented on Mar 15, 2022

    @gaaclarke
    gaaclarke
    on Mar 15, 2022 · Hidden as outdated

  16. gaaclarke commented on Mar 18, 2022

    @gaaclarke
    gaaclarke
    on Mar 18, 2022
    Member

    Okay, I was able to bisect again with the help of @petrhosek's llvm builds.

    The first confirmed bad commit is fad7e491a0770ac4336934030ac67d77e7af5520.

    Here is the bisect log: bisect5.txt

    Here is the graphical results of the bisect:

    caa1ebde70673ddb7124a0599ba846362a1f8b1e Don't assume that a new cleanup was added to InnermostEHScope.
...
######### Test 1 BAD ###################
bc48a266554740bbedbc155deda2aa81b9a1602d [LoopPeel] Use reference instead of pointer for DT argument
...
093b43f48d0d6d78e1dc102dc11507e1d6ef1624 Sink getGCResultLocality to sole use [NFC]
########## Test 2 ######################
22cd2356125ad4e2ade92b91fb0123f9afce182c [OpenMP] Disable rpath test in windows for lack of a libomp.lib stub
...
56cc697323445337134cc2bbe8ce8b1f60131574 [clang][dataflow] Merge distinct pointer values in Environment::join
###### Test 3 ##########################
efd4938723efeb26d9cf00ddf217149756c120c3 [VPlan] Handle IV vector splat using VPWidenCanonicalIV.
ee9eeed77348315abbf822034ade819fa741207a [X86] LowerFunnelShift - enable v8i16 lowering
6777289dd930393305703f0f8d992a4d648d43a7 [X86] lowerShuffleAsBlend - pull out repeated getVectorNumElements() calls. NFC.
3a1fd170271da25e7ce9b0a329adf47483378229 [WebAssembly] Use cast<> instead of dyn_cast<> to avoid dereference of nullptr
424400da2db86558917e6da19a821e160acc48d1 [clang][NFC] Change some ->getType()->isPlaceholderType() to just ->hasPlaceholderType()
f1305f2369dca985af777cf9c0cf06009d5bcbe8 [X86] combinePredicateReduction - always use PMOVMSKB(PCMPEQB()) for allof(icmp_eq()) reductions
a10ff373ddfa82a67c580a87f6258aa6ab8dd595 Speculatively fix the sphinx build for Clang's attribute reference
67a399fd57869805e5b7f7ce54ad0eab32a80a62 [X86] SimplifyDemandedBits - add X86ISD::BLENDV SimplifyMultipleUseDemandedBits handling
7e849fd97b6abd1de30ffc66da1ebf47afc7ab70 [X86] LowerFunnelShift - allow non-constant vXi8 unpack(y,x) << zext(z) lowering pre-AVX512
a6cabd98021fe357d666614601eca2031bf775de Revert fad7e491a0770ac4336934030ac67d77e7af5520 with fixes applied
33fe0872cd54afa1fc036e0d9fdc89d65449f9ff [M68k] Add addressing modes ARIPI and ARIPD support for BTST
30efee764d95d425b480758ed02682fab6426d28 [SVE] Remove AArch64ISD::PFALSE.
3bc876d0a3f1f7554b877b93c5f57ff7cba55ffa [AArch64] Add isel for bitcasting between bfloat and half types.
058c5dfc78cd1a1a6075bba9799e63f3ec871c0d Raise the minimum Visual Studio version to VS2019
784e01abca65722df8969b56d2d240cf9ced9c85 [IR] Require matching signature in getCalledFunction()
8faf2a0638d3e8d9411d55c3e5dfb7b452f35ca2 [RISCV] Correct predicate orc.b pattern to not include Zbkb.
864767ab09cba862d88d19ea6f1a17a1705175ad [WebAssembly][NFC] Refactor WasmSymbol type setting code
d8f929a567083a6b90264193f1e4476f6b77c5fe [RISCV] Custom legalize BITREVERSE with Zbkb.
c95df64ce06443d60881078ef2e80108e24459c4 [NFC] Add missing doxygen file tag in llvm/include/llvm/ADT/ headers
##### Test 5 ###########################
1aeb3314d8d77040527accc44aaf9d3959ac1f20 [TableGen] Detect multiple Processors with the same name.
7017e6c9cfd2de3122ce9528f338a97d61e96373 [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm
3b194ca7ab37a212ab54e698d22415753dc6a197 Recommit "[InstCombine] Fold and-reduce idiom"
be44177edea535d93af147cb7f26fae55f8da8ba [X86][avx512fp16] Promote fp16 to fp32 for frem.
106f2b2dfb35403ea581fdad15fa01db0f335e57 [gn build] (manually) port 99217fa8a02
521205c084f48607375d696465fd73f5728a9def [Test] Add pointer comparison test that crashed with D118317
1276678982a0c9d0d7aba6afdc83d34ee42f397c [RISCV] Improve extract_vector_elt for fixed mask registers.
bf4cab29f5a88b622e200d59d9156f2ca31165eb [Test] Recommit tests that were reverted by mistake along with other patch
e64feaf00fd3b42c5820da556e60dd575f98cbe5 [M68k][GlobalISel] Legalize more instruction in M68k Legalizer.
7e32d2b21a58ad71432f1403227dbf739f39c345 Revert "[UpdateTestChecks] Add --filter and --filter-out options"
##### Test 6 ###########################
4465c299069f3ff5b93ba648edf699faf7f39e79 Move LLVM Proposal to doc directory, create index
24f88f57de588817bd21e799e2ac1069c025674c [OpenMP] Accept shortened triples for -Xopenmp-target=
##### Test 7 BAD #######################
fad7e491a0770ac4336934030ac67d77e7af5520 Revert "Add BITINT_MAXWIDTH support"
##### Missing ##########################
5fc1261ef37549484e9eb9edc90477d713d8223f [Driver] Remove -fno-experimental-new-pass-manager
##### Missing ##########################
2081ffe4b2e3870cfe2d58331f57badd7dbc009a Update module map for 4ce1f3d47c33daccfb7f4e906c3f57b404900036
##### Missing ##########################
6eb826567af03c2b43cda78836b1065e12df84e4 [Driver] Add CUDA support for --offload param
##### Missing ##########################
99d2582164c4bc8f10c3e3c20dd3690243ad49ba [ScalarEvolution] Handle <= and >= in non infinite loops
##### Missing ##########################
354ec4af749ccd910a1cffc5e9cce2bb93239b9b [AttrDocs] Fix docs for the sycl_special_class attribute after D114483
#### Missing ###########################
030f71698d52f228929da5e3148602f4a3daff7d [UpdateTestChecks] Add --filter and --filter-out options
#### Missing ###########################
64df51624f08f3b8d7370f820ab3545b1de98a0e [clang-format] Fix misaligned trailing comments in the presence of an empty block comment.
##### Missing ##########################
be2147db054ec096199d1251bfab9065c7e0f29b Remove reference type when checking const structs
##### Missing ##########################
8428c75da1ab3149292c255057173cb502729d92 [CUDA][HIP] Do not treat host var address as constant in device compilation
##### Missing ##########################
6888081e32c45a7bb88cfc883a38bce5e5ccc0b8 [SLP] Use moveBefore to simplify code [NFC]
##### Missing ##########################
634ca7349d4a467b993321ff3152c2e044f1f487 [ObjCARC] Require the function argument in the clang.arc.attachedcall bundle.
##### Missing ##########################
9dd5fffd30651c5524a53d8110f75fa3b59666ac [GVN] Add tests with redundant load of pointer select.
##### Missing ##########################
746e435ff76a12468103a978d46f7b1a5052e867 Revert "[SLP] Add a clarifying assert in block scheduling [NFC]"
##### Missing ##########################
86797fdb6f51d32f285e48b6d3e0fc5b8b852734 Add BITINT_MAXWIDTH support
##### Test 4 GOOD ######################
edf7e026a8b4df5df7febaef126888f1ce65ebf6 [clang][NFC] Fix Typo
...
81bd67e18ae6ef90b68792f63eb94a10f22a353b [AArch64][SVE][VLS] Move extends into arguments of comparisons

    That means the culprit is one of these commits, but I can't confirm which one since there were missing builds:

    fad7e491a0770ac4336934030ac67d77e7af5520 Revert "Add BITINT_MAXWIDTH support"
5fc1261ef37549484e9eb9edc90477d713d8223f [Driver] Remove -fno-experimental-new-pass-manager
2081ffe4b2e3870cfe2d58331f57badd7dbc009a Update module map for 4ce1f3d47c33daccfb7f4e906c3f57b404900036
6eb826567af03c2b43cda78836b1065e12df84e4 [Driver] Add CUDA support for --offload param
99d2582164c4bc8f10c3e3c20dd3690243ad49ba [ScalarEvolution] Handle <= and >= in non infinite loops
354ec4af749ccd910a1cffc5e9cce2bb93239b9b [AttrDocs] Fix docs for the sycl_special_class attribute after D114483
030f71698d52f228929da5e3148602f4a3daff7d [UpdateTestChecks] Add --filter and --filter-out options
64df51624f08f3b8d7370f820ab3545b1de98a0e [clang-format] Fix misaligned trailing comments in the presence of an empty block comment.
be2147db054ec096199d1251bfab9065c7e0f29b Remove reference type when checking const structs
8428c75da1ab3149292c255057173cb502729d92 [CUDA][HIP] Do not treat host var address as constant in device compilation
6888081e32c45a7bb88cfc883a38bce5e5ccc0b8 [SLP] Use moveBefore to simplify code [NFC]
634ca7349d4a467b993321ff3152c2e044f1f487 [ObjCARC] Require the function argument in the clang.arc.attachedcall bundle.
9dd5fffd30651c5524a53d8110f75fa3b59666ac [GVN] Add tests with redundant load of pointer select.
746e435ff76a12468103a978d46f7b1a5052e867 Revert "[SLP] Add a clarifying assert in block scheduling [NFC]"
86797fdb6f51d32f285e48b6d3e0fc5b8b852734 Add BITINT_MAXWIDTH support

  17. gaaclarke commented on Mar 18, 2022

    @gaaclarke
    gaaclarke
    on Mar 18, 2022
    Member

    Okay, the final bisect has run. 634ca7349d4a467b993321ff3152c2e044f1f487 is absolutely the first bad commit.

    Bisect log: bisect6.txt

  18. zanderso commented on Mar 18, 2022

    @zanderso
    zanderso
    on Mar 18, 2022
    MemberAuthor

    @petrhosek what are the next steps? Is there anything further we can help you with?

  19. gaaclarke commented on Mar 18, 2022

    @gaaclarke
    gaaclarke
    on Mar 18, 2022
    Member

    It might be worth pinging Ahmed Bougacha on github ((at)ahmedbougacha) . He might be aware of the issue.

    I could also give you the whole compiled binary that fails but I worry that it is so big it isn't so helpful.

  20. petrhosek commented on Mar 19, 2022

    @petrhosek
    petrhosek
    on Mar 19, 2022
    Contributor

    I responded on https://reviews.llvm.org/D118214#3393603.

  21. bdero commented on May 3, 2022

    @bdero
    bdero
    on May 3, 2022
    Member

    Checked back on the bug for this today. Firefox bisected a crash to the same trouble commit, and it looks like a possible fix landed in LLVM 14.0.2.

  22. zanderso commented on May 4, 2022

    @zanderso
    zanderso
    on May 4, 2022
    MemberAuthor

    @petrhosek I'm not sure how to know when that fix will be available for Flutter to try out. Do you have any advice?

  23. petrhosek commented on May 12, 2022

    @petrhosek
    petrhosek
    on May 12, 2022
    Contributor

    @zanderso the current integration toolchain that's used by Fuchsia (that is git_revision:49cb4fef02e635bf304906232214166c7531d753) already contains that it.

  24. zanderso commented on May 12, 2022

    @zanderso
    zanderso
    on May 12, 2022
    MemberAuthor

    Great. I have restarted the autorollers.

  25. zanderso
    closed this as completedon Jun 27, 2022

  26. github-actions commented on Jul 11, 2022

    @github-actions
    github-actionsbot
    on Jul 11, 2022

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  27. github-actions
    locked as resolved and limited conversation to collaborators on Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High-priority issues at the top of the work listc: fatal crashCrashes that terminate the processdependency: fuchsiaFuchsia team may need to help usengineflutter/engine related. See also e: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions