error: definition of implicit copy assignment operator for 'SaveLayerOptions' is deprecated because it has a user-declared copy constructor

@flar

Version of clang in Xcode 13.0 has a new error:

In file included from ../../flutter/display_list/display_list_builder.h:8:
../../flutter/display_list/display_list.h:158:3: error: definition of implicit copy assignment operator for 'SaveLayerOptions' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
  SaveLayerOptions(const SaveLayerOptions& options) : flags_(options.flags_) {}
  ^
../../flutter/display_list/display_list_builder.cc:283:21: note: in implicit copy assignment operator for 'flutter::SaveLayerOptions' first required here
        op->options = op->options.with_can_distribute_opacity();

Seen in flutter-team-archive/engine#31915 https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8820208992595983441/+/u/build_ios_debug_sim_arm64/stdout

Blocking #85555

flutter-team-archive/engine#30957 @flar

It looks like it needs an explicit copy operator now. This patch might fix it?

diff --git a/display_list/display_list.h b/display_list/display_list.h
index ba255b576b..5fc03fc30d 100644
--- a/display_list/display_list.h
+++ b/display_list/display_list.h
@@ -181,6 +181,11 @@ class SaveLayerOptions {
     return options;
   }
 
+  SaveLayerOptions& operator=(const SaveLayerOptions& other) {
+    flags_ = other.flags_;
+    return *this;
+  }
+
   bool operator==(const SaveLayerOptions& other) const {
     return flags_ == other.flags_;
   }

@flar

It worked, thanks @flar!
https://ci.chromium.org/p/flutter/builders/try/Mac%20iOS%20Engine/28380

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

Navigation Menu

Repository navigation

error: definition of implicit copy assignment operator for 'SaveLayerOptions' is deprecated because it has a user-declared copy constructor #99795

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

error: definition of implicit copy assignment operator for 'SaveLayerOptions' is deprecated because it has a user-declared copy constructor #99795

Description

Activity

flar commented on Mar 9, 2022

jmagman commented on Mar 9, 2022

github-actions commented on Mar 24, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions