Repository navigation
Reland "Hide text selection toolbar when dragging handles on mobile" - #105362
Closed
markusaksli-nc wants to merge 1 commit into
Closed
markusaksli-nc wants to merge 1 commit into
markusaksli-nc wants to merge 1 commit into
Conversation
flutter-dashboard
Bot
added
a: text input
justinmc
approved these changes
Aug 24, 2022
justinmc
left a comment
justinmc
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
So sorry I missed this notification!
TahaTesser
force-pushed
the
handle-hide-toolbar
branch
from
August 24, 2022 07:49
81a880a to
cf5eb7c
Compare
Contributor
|
@TahaTesser It seems like there is a legit test failure after that push. I almost just pressed the merge button last night but maybe it's good that I didn't. Thanks for updating it. |
Contributor
Author
|
Thanks @TahaTesser for the rebase. @justinmc I'll be back from vacation Monday, and I'll take a look at the test failure. |
Contributor
|
Sounds good, enjoy your vacation! |
Contributor
Author
|
It looks like this was already implemented with the magnifier |
Contributor
|
Ah sorry I should have realized that and closed the issue. Anyway, glad it's fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relands #104274
Fixes #62193