Adds shape, collapsedShape properties to Expansion Tile - #108861

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Maybe it is better to use borderShape/borderSide and collapsedBorderShape/collapsedBorderSide? Then other parameters could also be edited. Maybe, just an idea.

Also, your PR is missing tests.

Maybe it is better to use borderShape/borderSide and collapsedBorderShape/collapsedBorderSide? Then other parameters could also be edited. Maybe, just an idea.

We could do that, But the problem is the animation. If we are specifying the border parameter then we can't run animation on it

You can. Most borders lerp between each other. BorderSide also lerps.

You can. Most borders lerp between each other. BorderSide also lerps.

Oh, I'll look into it

Added Test case for checking Expansion panel Border

It looks like some tests are failing, can you take a look? Also, why not add this to the theme as well like the other properties?

Hi @Piinks,

• I don't know why Linux doc test is failing.
  Can you help me with that?

• Can we consider Border as a property of ExpansionTileThemeData? (Border doesn't fit the context of theme, is what i thought). I'll add it now.

Thank you for your suggestions.

It is failing because the PR needs to be rebased on top of the last flutter master (it is using a too old version for the CI). You rebase, then force push.

Clip is not working on the splash of ListTile in expansion tile.

• press and hold expansion tile after expanding it.

• execute in this branch

import 'package:flutter/material.dart';
import 'package:flutter/widgets.dart';

void main() => runApp(
      MaterialApp(
        home: Scaffold(
          body: Padding(
            padding: const EdgeInsets.all(64.0),
            child: Center(
              child: ExpansionTile(
                backgroundColor: Colors.red,
                collapsedBackgroundColor: Colors.green,
                shape: CircleBorder(
                  side: BorderSide(),
                  // borderRadius: BorderRadius.circular(300),
                ),
                title: Text(
                  'Hello, world!',
                  key: Key('title'),
                  textDirection: TextDirection.ltr,
                ),
                children: [
                  Text(
                    'Hello, world!',
                    textDirection: TextDirection.ltr,
                  ),
                  Text(
                    'Hello, world!',
                    textDirection: TextDirection.ltr,
                  ),
                  Text(
                    'Hello, world!',
                    textDirection: TextDirection.ltr,
                  ),
                  Text(
                    'Hello, world!',
                    textDirection: TextDirection.ltr,
                  ),
                ],
              ),
            ),
          ),
        ),
      ),
    );

The docs test is failing because you have a reference in the docs that can't be resolved:

dartdoc:stderr:   error: unresolved doc reference [Theme.divider]
dartdoc:stderr:     from material.ExpansionTile.shape: (file:///b/s/w/ir/x/w/flutter%20sdk/packages/flutter/lib/src/material/expansion_tile.dart:269:22)
dartdoc:stderr:     in documentation inherited from material.ExpansionTile.shape: (file:///b/s/w/ir/x/w/flutter%20sdk/packages/flutter/lib/src/material/expansion_tile.dart:269:22)

Clip is not working on the splash of ListTile in expansion tile.

Is this not the expected behavior?

Clip is not working on the splash of ListTile in expansion tile.

Is this not the expected behavior?

oh, I thought it should not, as the ListTile has been clipped by the container.

I can't quite tell what this is achieving versus the original default. Can you add an image before/after your change of the default tile? I think this might be a breaking change, so I am running it through additional tests to check.

• Previously (this is the default and the user cannot edit it (for example the border shape or color))

• With this PR (the user can edit the shape and color of the borders )

It looks like CI is failing, can you rebase with the latest on master?

This PR looks like it was branched off of a different branch from master, resulting in a large diff and meaning it will not be mergeable. Please see tree hygiene for more details about how to open pull requests to Flutter repositories.

This PR looks like it was branched off of a different branch from master, resulting in a large diff and meaning it will not be mergeable. Please see tree hygiene for more details about how to open pull requests to Flutter repositories.

Should I force undo the merge commit and rebase with git fetch upstream; git rebase upstream/master; git push origin your_branch_name ?

sorry but I think I messed up. I lost all my commits is there any way to undo it?

git reflog is your friend

I wasn't able to rebase the repo, when I tried I'm getting a suggestion to push 24 changes as shown bellow.

Should I open another PR?

You can open a new PR, but git reflog is also pretty helpful if you want to rollback to an earlier state.

I've rolled back to previous commit. This is happening after that.

Have you tried rebasing again after rolling back? I can't be of much help troubleshooting git unfortunately. If opening a new PR is easier, that's ok to do! :)

you click in your github flutter fork to sync changes
you checkout, then pull master (fetch + reset --hard works)
you checkout your branch, you rebase this branch on top of master (right click on origin/master, rebase thisBranch)
you force push (git push --force)

if git is too hard, you can use IntelliJ, its git features are really good.