Repository navigation
Conversation
flutter-dashboard
Bot
added
a: tests
Contributor
Author
|
@yjbanov WDYT of something like this? You don't need to rewrite and copy paste everything. It can be simple. :) |
1 of 4 tasks
Piinks
commented
Oct 25, 2022
| bool isFlaky = false, | ||
| }) { | ||
| if (isFlaky) { | ||
| (goldenFileComparator as flutter_goldens.FlutterGoldenFileComparator).testIsFlaky(); |
Contributor
Author
There was a problem hiding this comment.
Also @yjbanov instead of setting a boolean flag here, you could pass the goldenFile and the comparator could handle the flaky test that way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.