Skip to content

Make tear-offs cacheable for RenderSemanticsGestureHandler - #11556

Merged
goderbauer merged 3 commits into
flutter:masterfrom
goderbauer:fixTearOff
Aug 8, 2017
Merged

goderbauer merged 3 commits into
flutter:masterfrom
goderbauer:fixTearOff

Conversation

@goderbauer

@goderbauer goderbauer commented Aug 8, 2017 •

Copy link
Copy Markdown
Member

Fixes #11552.

@goderbauer goderbauer changed the title Fix tear off Make tear-offs cachable for RenderSemanticsGestureHandler Aug 8, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have this call _updateHandlers directly? Having it bounce through updateRenderObject is weird.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Changed.

@Hixie

Hixie commented Aug 8, 2017

Copy link
Copy Markdown
Contributor

LGTM

@goderbauer goderbauer changed the title Make tear-offs cachable for RenderSemanticsGestureHandler Make tear-offs cacheable for RenderSemanticsGestureHandler Aug 8, 2017
@goderbauer
goderbauer merged commit 3b76e7e into flutter:master Aug 8, 2017
@goderbauer
goderbauer deleted the fixTearOff branch August 8, 2017 22:46
@goderbauer goderbauer added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Oct 17, 2017
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Caching callbacks in RenderSemanticsGestureHandler doesn't work as expected

3 participants