Repository navigation
[roll + cherrypick] Revert "Speed up first asset load by encoding asset manifest in binar… - #116672
Conversation
…y rather than JSON (flutter#113637)" (flutter#116662) This reverts commit 56cad89.
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
flutter-dashboard
Bot
added
framework
|
I want to make sure analysis passes on this, as there are pubspec changes |
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
Tool revert LGTM
|
@XilaiZhang do you know why the bot didn't approve this? CPs for rolls should be bot approved |
|
umm my understanding might be wrong, but I remember Godofredo mentioned a while ago that autosubmit bot does not work on release branches, or maybe it now works on release branches as well |
|
Approval != autosubmit. You shouldn't be blocked on landing roll CPs as the bot will approve them |
|
Synced with Casey and learnt about auto approve from a cocoon bot. Casey added my name to the bot config so in the future roll cherry picks will be auto approved by the bot |
3 participants
…y rather than JSON (#113637)" (#116662)
This reverts commit 56cad89.
cherrypicks #116662. cherry pick for now and not updating to head so that we might be able to fix all current failures and get going.