Skip to content

BorderRadius RTL - #12149

Merged
Hixie merged 1 commit into
flutter:masterfrom
Hixie:border_radius
Sep 20, 2017
Merged

Hixie merged 1 commit into
flutter:masterfrom
Hixie:border_radius

Conversation

@Hixie

@Hixie Hixie commented Sep 18, 2017

Copy link
Copy Markdown
Contributor

Add an RTL version of BorderRadius.
Minor fixes to EdgeInsets to match.

Add an RTL version of BorderRadius.
Minor fixes to EdgeInsets to match.
@Hixie

Hixie commented Sep 18, 2017

Copy link
Copy Markdown
Contributor Author

cc @abarth

/// Base class for [BorderRadius] that allows for text-direction aware resolution.
///
/// A property or argument of this type accepts classes created either with [new
/// BorderRadius.only] and its variants, or [new BorderRadiusDirectional.only]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this line break mess up the docs? It messes up GitHub's colorization.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure dartdoc handles this fine, but I'll try to remember to check.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, looks fine

@abarth

abarth commented Sep 20, 2017

Copy link
Copy Markdown
Contributor

LGTM

@Hixie
Hixie merged commit 1f05c2c into flutter:master Sep 20, 2017
@Hixie
Hixie deleted the border_radius branch September 20, 2017 20:42
@Hixie Hixie mentioned this pull request Sep 20, 2017
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants