Repository navigation
Revert "Treat hidden IndexedStack children as offstage for test finder" - #124035
Closed
CaseyHillers wants to merge 1 commit into
Closed
CaseyHillers wants to merge 1 commit into
CaseyHillers wants to merge 1 commit into
Conversation
flutter-dashboard
Bot
added
a: tests
7 of 8 tasks
Member
|
This shouldn't be necessary as a g3fix for those failures has been scheduled. We can leave it open in case the g3fix fails for some reason, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #123129
This is breaking Google Testing. 2 tests are failing to find widgets that used to be findable. They're able to find when
skipOffstageis set to false.